httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@gonzo.ben.algroup.co.uk>
Subject 05_AddDescription
Date Sat, 16 Sep 1995 10:49:24 GMT
I've started reviewing the other patches, and it seems to me that 05_AddDesc...
is wrong (or at least suboptimal), I think it should be like this:

*** ../../apache_0.8.13/src/mod_dir.c   Fri Sep  8 20:22:22 1995
--- mod_dir.c   Sat Sep 16 11:41:21 1995
***************
*** 239,245 ****
      "one or more index options" },
  { "IndexIgnore", add_ignore, NULL, DIR_CMD_PERMS, ITERATE,
      "one or more file extensions" },
! { "AddDescription", add_desc, NULL, DIR_CMD_PERMS, ITERATE2,
      "Descriptive text followed by one or more filenames" },
  { "HeaderName", add_header, NULL, DIR_CMD_PERMS, TAKE1, "a filename" },
  { "ReadmeName", add_readme, NULL, DIR_CMD_PERMS, TAKE1, "a filename" },
--- 239,245 ----
      "one or more index options" },
  { "IndexIgnore", add_ignore, NULL, DIR_CMD_PERMS, ITERATE,
      "one or more file extensions" },
! { "AddDescription", add_desc, BY_PATH, DIR_CMD_PERMS, ITERATE2,
      "Descriptive text followed by one or more filenames" },
  { "HeaderName", add_header, NULL, DIR_CMD_PERMS, TAKE1, "a filename" },
  { "ReadmeName", add_readme, NULL, DIR_CMD_PERMS, TAKE1, "a filename" },

So, I'd like to add this as 05b_AddDesc...

Aram, is it OK if I just post this, or do you want me to upload it, too?

Cheers,

Ben.

-- 
Ben Laurie                  Phone: +44 (181) 994 6435
Freelance Consultant        Fax:   +44 (181) 994 6472
and Technical Director      Email: ben@algroup.co.uk (preferred)
A.L. Digital Ltd,                  benl@fear.demon.co.uk (backup)
London, England.

[Note for the paranoid: "fear" as in "Fear and Loathing
in Las Vegas", "demon" as in Demon Internet Services, a
commercial Internet access provider.]

Mime
View raw message