httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@ai.mit.edu (Robert S. Thau)
Subject Re: XBITHACK trips people up
Date Fri, 22 Sep 1995 17:41:12 GMT
XBITHACK works on *all* files in the base code (if it has the XBIT on, and
it isn't a CGI script, it gets full includes processing).  There may be
people relying on this.  It should *certainly* be on for at least all of
text/* (your patch would disallow it for html3 files; also, it core dumps
if no content type was identified from suffix, and r->content_type is NULL;
it should check the default_type in that case if we want to do this at all,
which I doubt).

*** mod_include.c.orig  Fri Sep 22 09:50:43 1995
--- mod_include.c       Fri Sep 22 10:02:07 1995
***************
*** 838,843 ****
--- 838,846 ----
                                               &includes_module);
      
      if (*state == xbithack_off) return DECLINED;
+     
+     if (strcmp(r->content_type, "text/html")) return DECLINED;
+     
      return send_parsed_file (r);
  }
  


Mime
View raw message