httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: SIGSEGV problem
Date Fri, 11 Aug 1995 17:05:24 GMT
Jim Jagielski so wisely writes:
> 
> I've finally gotten a good enough core to look at. It seems that the
> problem is in the log_transaction(timeout_req) call in timeout().
> 

Uggg.... I think I know what it is... In common_log_transaction(), the
sprint refers to 'orig->the_request'. However, when read times out,
the_request is most probably null since, after all, we didn't get one
yet. So the sprintf() tries to access NULL to fill in %s.

I'm guessing we could (in mod_log_common.c)::

*** Omod_log_common.c	Fri Aug 11 13:02:24 1995
--- mod_log_common.c	Fri Aug 11 13:03:13 1995
***************
*** 182,188 ****
              sign,
              timz/3600,
              timz%3600,
!             orig->the_request);
      
      if (r->status != -1)
          sprintf(str,"%s%d ",str,r->status);
--- 182,188 ----
              sign,
              timz/3600,
              timz%3600,
!             (orig->the_request ? orig->the_request : "NULL") );
      
      if (r->status != -1)
          sprintf(str,"%s%d ",str,r->status);
-- 
Jim Jagielski  << jim@jaguNET.com >>   | "Stwike him Centuwian, vewy woughwy!"
  **  jaguNET Access Services  **      |                - Pontius Piwate
++       Email: info@jaguNET.com      +++        Voice:  410-931-3157       ++
++       http://www.jaguNET.com/      +++      Data: 931-7060 ("guest")     ++

Mime
View raw message