httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d...@ast.cam.ac.uk (David Robinson)
Subject Re: 0.6.2 must go
Date Thu, 11 May 1995 18:18:00 GMT
>It squeezes spaces such as
>
>Content-type:   text/html
>
>to
>
>Content-type: text/html
>
>
>Someone pointed out that a script he was using barfed with the
>multiple spaces.

In fact, according to the current HTTP spec, the first form is not allowed!
(I think that is an oversight.)

So this is a reasonable adjustment for httpd to make.
HOWEVER, if you look further to where 'l' is being used in the routine that
you modified, you will see that your patch breaks any header which the script
returns that is not parsed by httpd.
i.e. with your patch, a script that returns a header of
J-random-header: value
to httpd causes httpd to send a header of
J-random-header
to the client.

I suggest that instead of playing around with pointers, you either rewrite
the header (with memmove or similar), _or_ split up the header into
name/value once and for all, and get rid of the hack of inserting and removing
'\0' from the header string.

 David.

Mime
View raw message