Message-Id: <199503141348.HAA00705@sierra.zyzzyva.com>
To: new-httpd@hyperreal.com
Subject: Re: Compiling with -Wall 
In-reply-to: rst's message of Tue, 14 Mar 1995 09:18:18 -0500.
         <9503141418.AA03109@volterra>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Date: Tue, 14 Mar 1995 07:48:55 -0600
From: Randy Terbush <randy@zyzzyva.com>
Sender: owner-new-httpd@hyperreal.com
Precedence: bulk
Reply-To: new-httpd@hyperreal.com

>    X-Uri: http://www.inetnebr.com/zyzzyva
>    Date: Tue, 14 Mar 1995 07:15:21 -0600
>    From: Randy Terbush <randy@zyzzyva.com>
> 
>    > I certainly think that these warnings should be fixed, and the coding
>    > style in general needs improving. However, right now I think we want
>    > to avoid changing too many source files. Not only would we move further
>    > away from the NCSA source, but it also makes it a little harder to
>    > integrate patches with one-another.
>    > 
>    > The majority of your changes are to remove redundent variables (of which
>    > there are sadly too many) -- which an optimising compiler would do anyway,
>    > and to insert parenthesis around assignments in conditional expressions.
>    > May I suggest that you trim down the patch to include only the bug fixes?
> 
>    Point well taken.  I will trim this and resubmit it.
> 
> Aw, drat.  The content-negotiation stuff really does need another
> pass, and I was looking forward to finally being able to use -Wall
> while debugging it.  (I suppose I could have the Makefile turn it on
> only for http_mime_db.c for the time being).
> 
> Brian and Cliff have both been doing integration --- has this been a
> problem so far?

I don't *have* to remove this. :-) I have been testing my changes locally,
and with exception of the one *nasty* bug I created that Brian pointed
out, I don't think any of these changes caused other problems.