httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kot...@apache.org
Subject svn commit: r1801146 - /httpd/httpd/trunk/server/mpm/winnt/child.c
Date Fri, 07 Jul 2017 11:08:27 GMT
Author: kotkov
Date: Fri Jul  7 11:08:26 2017
New Revision: 1801146

URL: http://svn.apache.org/viewvc?rev=1801146&view=rev
Log:
mpm_winnt: Remove an unnecessary retry after receiving a non-timeout failure
from the mpm_get_completion_context() function.

Currently, the only possible reasons why mpm_get_completion_context() could
fail are real errors such as being unable to WaitForSingleObject(), allocate
memory or create an event.  Retrying under such circumstances doesn't make
sense, and could be as well considered harmful.

Modified:
    httpd/httpd/trunk/server/mpm/winnt/child.c

Modified: httpd/httpd/trunk/server/mpm/winnt/child.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/mpm/winnt/child.c?rev=1801146&r1=1801145&r2=1801146&view=diff
==============================================================================
--- httpd/httpd/trunk/server/mpm/winnt/child.c (original)
+++ httpd/httpd/trunk/server/mpm/winnt/child.c Fri Jul  7 11:08:26 2017
@@ -438,14 +438,7 @@ reinit: /* target of connect upon too ma
             context = mpm_get_completion_context(&timeout);
             if (!context) {
                 if (!timeout) {
-                    /* Hopefully a temporary condition in the provider? */
-                    ++err_count;
-                    if (err_count > MAX_ACCEPTEX_ERR_COUNT) {
-                        ap_log_error(APLOG_MARK, APLOG_CRIT, 0, ap_server_conf, APLOGNO(00335)
-                                     "winnt_accept: Too many failures grabbing a "
-                                     "connection ctx.  Aborting.");
-                        break;
-                    }
+                    break;
                 }
                 Sleep(100);
                 continue;



Mime
View raw message