httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jchamp...@apache.org
Subject svn commit: r1782518 - in /httpd/test/framework/trunk/t: conf/proxy.conf.in modules/proxy_fcgi.t
Date Fri, 10 Feb 2017 20:29:40 GMT
Author: jchampion
Date: Fri Feb 10 20:29:40 2017
New Revision: 1782518

URL: http://svn.apache.org/viewvc?rev=1782518&view=rev
Log:
mod_proxy_fcgi: fix up unset test

PATH_TRANSLATED wasn't being set by the server, so the test for undef
would pass regardless of whether the module worked. Switch to use a
CGI-required variable (REMOTE_ADDR).

Modified:
    httpd/test/framework/trunk/t/conf/proxy.conf.in
    httpd/test/framework/trunk/t/modules/proxy_fcgi.t

Modified: httpd/test/framework/trunk/t/conf/proxy.conf.in
URL: http://svn.apache.org/viewvc/httpd/test/framework/trunk/t/conf/proxy.conf.in?rev=1782518&r1=1782517&r2=1782518&view=diff
==============================================================================
--- httpd/test/framework/trunk/t/conf/proxy.conf.in (original)
+++ httpd/test/framework/trunk/t/conf/proxy.conf.in Fri Feb 10 20:29:40 2017
@@ -60,7 +60,7 @@
         ProxyFCGISetEnvIf false TEST_NOT_SET
         ProxyFCGISetEnvIf true  TEST_DOCROOT "%{DOCUMENT_ROOT}"
         ProxyFCGISetEnvIf "reqenv('GATEWAY_INTERFACE') =~ m#CGI/(.\..)#" TEST_CGI_VERSION
"v$1"
-        ProxyFCGISetEnvIf true !PATH_TRANSLATED
+        ProxyFCGISetEnvIf true !REMOTE_ADDR
       </Location>
     </IfVersion>
   </VirtualHost>

Modified: httpd/test/framework/trunk/t/modules/proxy_fcgi.t
URL: http://svn.apache.org/viewvc/httpd/test/framework/trunk/t/modules/proxy_fcgi.t?rev=1782518&r1=1782517&r2=1782518&view=diff
==============================================================================
--- httpd/test/framework/trunk/t/modules/proxy_fcgi.t (original)
+++ httpd/test/framework/trunk/t/modules/proxy_fcgi.t Fri Feb 10 20:29:40 2017
@@ -117,7 +117,7 @@ ok t_cmp($envs{'TEST_NOT_SET'},     unde
 ok t_cmp($envs{'TEST_EMPTY'},       '',           "ProxyFCGISetEnvIf can set empty values");
 ok t_cmp($envs{'TEST_DOCROOT'},     $docroot,     "ProxyFCGISetEnvIf can replace with request
variables");
 ok t_cmp($envs{'TEST_CGI_VERSION'}, 'v1.1',       "ProxyFCGISetEnvIf can replace with backreferences");
-ok t_cmp($envs{'PATH_TRANSLATED'}, undef,         "ProxyFCGISetEnvIf can unset var");
+ok t_cmp($envs{'REMOTE_ADDR'},      undef,        "ProxyFCGISetEnvIf can unset var");
 
 # Rejoin the child FCGI process.
 waitpid($child, 0);



Mime
View raw message