Mailing-List: contact cvs-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r1774008 - in /httpd/httpd/trunk:
 docs/log-message-tags/next-number modules/filters/mod_ratelimit.c
Date: Tue, 13 Dec 2016 13:15:59 -0000
To: cvs@httpd.apache.org
From: jim@apache.org
Message-Id: <20161213131600.60F1D3A0335@svn01-us-west.apache.org>
archived-at: Tue, 13 Dec 2016 13:16:03 -0000

Author: jim
Date: Tue Dec 13 13:15:59 2016
New Revision: 1774008

URL: http://svn.apache.org/viewvc?rev=1774008&view=rev
Log:
Some "error" reporting if we overflow

Modified:
    httpd/httpd/trunk/docs/log-message-tags/next-number
    httpd/httpd/trunk/modules/filters/mod_ratelimit.c

Modified: httpd/httpd/trunk/docs/log-message-tags/next-number
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/docs/log-message-tags/next-number?rev=1774008&r1=1774007&r2=1774008&view=diff
==============================================================================
--- httpd/httpd/trunk/docs/log-message-tags/next-number (original)
+++ httpd/httpd/trunk/docs/log-message-tags/next-number Tue Dec 13 13:15:59 2016
@@ -1 +1 @@
-3488
+3490

Modified: httpd/httpd/trunk/modules/filters/mod_ratelimit.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/filters/mod_ratelimit.c?rev=1774008&r1=1774007&r2=1774008&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/filters/mod_ratelimit.c (original)
+++ httpd/httpd/trunk/modules/filters/mod_ratelimit.c Tue Dec 13 13:15:59 2016
@@ -97,6 +97,8 @@ rate_limit_filter(ap_filter_t *f, apr_bu
         ratelimit = atoi(rl) * 1024;
         if (ratelimit <= 0) {
             /* remove ourselves */
+            ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, f->r,
+                          APLOGNO(03488) "rl: disabling: rate-limit = %s (too high?)", rl);
             ap_remove_output_filter(f);
             return ap_pass_brigade(f->next, bb);
         }
@@ -106,7 +108,9 @@ rate_limit_filter(ap_filter_t *f, apr_bu
         if (rl != NULL) {
             burst = atoi(rl) * 1024;
             if (burst <= 0) {
-                burst = 0;
+               ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, f->r,
+                             APLOGNO(03489) "rl: disabling burst: rate-initial-burst = %s (too high?)", rl);
+               burst = 0;
             }
         }