httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jacob Champion <champio...@gmail.com>
Subject Re: svn commit: r1760113 - /httpd/httpd/branches/2.4.x/STATUS
Date Wed, 28 Sep 2016 16:54:40 GMT
On 09/09/2016 03:09 PM, ylavic@apache.org wrote:
> +
> +  *) Fix warnings with new compilers, warnings treated as error
> +     in maintainer-mode, standard c-89 is enforced
> +     trunk patch: http://svn.apache.org/r1702948

This part of the patch has the following addition:

> Index: configure.in
> ===================================================================
> --- configure.in	(revision 1760112)
> +++ configure.in	(working copy)
> @@ -596,11 +596,12 @@ AC_ARG_ENABLE(maintainer-mode,APACHE_HELP_STRING(-
>      APR_ADDTO(CPPFLAGS, -DAP_DEBUG)
>      if test "$GCC" = "yes"; then
>        APR_ADDTO(CFLAGS,[-Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations
-Wpointer-arith])
> +      APACHE_ADD_GCC_CFLAG([-std=c89])
> +      APACHE_ADD_GCC_CFLAG([-Werror])
>        APACHE_ADD_GCC_CFLAG([-Wdeclaration-after-statement])
> -      APACHE_ADD_GCC_CFLAG([-Werror=declaration-after-statement])
>        APACHE_ADD_GCC_CFLAG([-Wformat])
>        APACHE_ADD_GCC_CFLAG([-Wformat-security])
> -      APACHE_ADD_GCC_CFLAG([-Werror=format-security])
> +      APACHE_ADD_GCC_CFLAG([-Wunused])
>      elif test "$AIX_XLC" = "yes"; then
>        APR_ADDTO(CFLAGS,-qfullpath -qinitauto=FE -qcheck=all -qinfo=pro)
>      fi

On my machine, the -Werror flag is never added, because 
-Wstrict-prototypes complains about AC_LANG_PROGRAM's use of main() 
instead of main(void) and the compilation check fails.

(I tried moving the -Werror addition before the APR_ADDTO line that adds 
-Wstrict-prototypes, but predictably, this just moves the problem down 
the road, since other test programs fail later.)

--Jacob

Mime
View raw message