httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s.@apache.org
Subject svn commit: r1757061 - in /httpd/httpd/trunk: include/mpm_common.h server/mpm_unix.c
Date Sun, 21 Aug 2016 14:09:00 GMT
Author: sf
Date: Sun Aug 21 14:09:00 2016
New Revision: 1757061

URL: http://svn.apache.org/viewvc?rev=1757061&view=rev
Log:
ap_reclaim_child_processes() ignores its first argument

note this in the docs, add comment

Modified:
    httpd/httpd/trunk/include/mpm_common.h
    httpd/httpd/trunk/server/mpm_unix.c

Modified: httpd/httpd/trunk/include/mpm_common.h
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/include/mpm_common.h?rev=1757061&r1=1757060&r2=1757061&view=diff
==============================================================================
--- httpd/httpd/trunk/include/mpm_common.h (original)
+++ httpd/httpd/trunk/include/mpm_common.h Sun Aug 21 14:09:00 2016
@@ -94,7 +94,8 @@ typedef void ap_reclaim_callback_fn_t(in
  * Make sure all child processes that have been spawned by the parent process
  * have died.  This includes process registered as "other_children".
  *
- * @param terminate Either 1 or 0.  If 1, send the child processes SIGTERM
+ * @param terminate Not Implemented, value is ignored !!!
+ *        Either 1 or 0.  If 1, send the child processes SIGTERM
  *        each time through the loop.  If 0, give the process time to die
  *        on its own before signalling it.
  * @param mpm_callback Callback invoked for each dead child process

Modified: httpd/httpd/trunk/server/mpm_unix.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/mpm_unix.c?rev=1757061&r1=1757060&r2=1757061&view=diff
==============================================================================
--- httpd/httpd/trunk/server/mpm_unix.c (original)
+++ httpd/httpd/trunk/server/mpm_unix.c Sun Aug 21 14:09:00 2016
@@ -173,6 +173,7 @@ static int reclaim_one_pid(pid_t pid, ac
     return 0;
 }
 
+/* XXX The terminate argument is ignored. Implement or remove? */
 AP_DECLARE(void) ap_reclaim_child_processes(int terminate,
                                             ap_reclaim_callback_fn_t *mpm_callback)
 {



Mime
View raw message