httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From elu...@apache.org
Subject svn commit: r1750747 - /httpd/httpd/trunk/server/util_script.c
Date Thu, 30 Jun 2016 07:00:31 GMT
Author: elukey
Date: Thu Jun 30 07:00:31 2016
New Revision: 1750747

URL: http://svn.apache.org/viewvc?rev=1750747&view=rev
Log:
Log CGI/FCGI Last-Modified header value changes.

The Last-Modified header coming from a backend FCGI/CGI script is inspected
by util_script.c to enforce RFC2616 (https://tools.ietf.org/html/rfc2616#section-14.29).
The Last-Modified header also needs to be compliant with RFC882/1123 as stated in
https://tools.ietf.org/html/rfc2616#section-3.3.1, and one important assumption that
httpd makes (correctly, as the RFC suggests) is to assume the GMT timezone. If the datestr
returned by the FCGI/CGI script is set with a different timezone, then the value might be
considered
"in the future" and replaced with GMT now() as calculated by httpd. Adding a trace log might
help sysadmins while debugging these kind of issues. This is a follow up of r1748379. 
  

Modified:
    httpd/httpd/trunk/server/util_script.c

Modified: httpd/httpd/trunk/server/util_script.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/util_script.c?rev=1750747&r1=1750746&r2=1750747&view=diff
==============================================================================
--- httpd/httpd/trunk/server/util_script.c (original)
+++ httpd/httpd/trunk/server/util_script.c Thu Jun 30 07:00:31 2016
@@ -669,6 +669,25 @@ AP_DECLARE(int) ap_scan_script_header_er
             if (last_modified_date != APR_DATE_BAD) {
                 ap_update_mtime(r, last_modified_date);
                 ap_set_last_modified(r);
+                if (APLOGrtrace1(r)) {
+                    const char* datestr = apr_table_get(r->headers_out, 
+                                                        "Last-Modified");
+                    apr_time_t timestamp = apr_date_parse_http(datestr);
+                    if (timestamp < last_modified_date) {
+                        char *last_modified_datestr = apr_palloc(r->pool,
+                                                                 APR_RFC822_DATE_LEN);
+                        apr_rfc822_date(last_modified_datestr, last_modified_date);
+                        ap_log_rerror(SCRIPT_LOG_MARK, APLOG_TRACE1, 0, r,
+                                 "The Last-Modified header value '%s' "
+                                 "(parsed as RFC882/RFC1123 datetime, "
+                                 "that assumes the GMT timezone) "
+                                 "has been replaced with: '%s'. "
+                                 "An origin server with a clock must not send "
+                                 "a Last-Modified date that is later than the "
+                                 "server's time of message origination.", 
+                                 last_modified_datestr, datestr);
+                    }
+                }
             }
             else {
                 if (APLOGrtrace1(r))



Mime
View raw message