Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D0808200AEF for ; Sat, 14 May 2016 08:23:31 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CF190160A12; Sat, 14 May 2016 06:23:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 22B6416099F for ; Sat, 14 May 2016 08:23:30 +0200 (CEST) Received: (qmail 6358 invoked by uid 500); 14 May 2016 06:23:30 -0000 Mailing-List: contact cvs-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list cvs@httpd.apache.org Received: (qmail 6349 invoked by uid 99); 14 May 2016 06:23:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 May 2016 06:23:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id E00341A1252 for ; Sat, 14 May 2016 06:23:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.999 X-Spam-Level: X-Spam-Status: No, score=0.999 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 3pIZdSsz0n8A for ; Sat, 14 May 2016 06:23:29 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTP id 7472B5F2C3 for ; Sat, 14 May 2016 06:23:28 +0000 (UTC) Received: from svn01-us-west.apache.org (svn.apache.org [10.41.0.6]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 52056E0185 for ; Sat, 14 May 2016 06:23:27 +0000 (UTC) Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id 783C23A0051 for ; Sat, 14 May 2016 06:23:26 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1743788 - /httpd/httpd/trunk/modules/http2/h2_proxy_session.c Date: Sat, 14 May 2016 06:23:26 -0000 To: cvs@httpd.apache.org From: jailletc36@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20160514062326.783C23A0051@svn01-us-west.apache.org> archived-at: Sat, 14 May 2016 06:23:32 -0000 Author: jailletc36 Date: Sat May 14 06:23:25 2016 New Revision: 1743788 URL: http://svn.apache.org/viewvc?rev=1743788&view=rev Log: Fix NULL pointer dereference Modified: httpd/httpd/trunk/modules/http2/h2_proxy_session.c Modified: httpd/httpd/trunk/modules/http2/h2_proxy_session.c URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http2/h2_proxy_session.c?rev=1743788&r1=1743787&r2=1743788&view=diff ============================================================================== --- httpd/httpd/trunk/modules/http2/h2_proxy_session.c (original) +++ httpd/httpd/trunk/modules/http2/h2_proxy_session.c Sat May 14 06:23:25 2016 @@ -336,10 +336,10 @@ static int on_data_chunk_recv(nghttp2_se stream = nghttp2_session_get_stream_user_data(ngh2, stream_id); if (!stream) { - ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, stream->r, APLOGNO(03358) - "h2_proxy_session(%s): recv data chunk for " - "unknown stream %d, ignored", - session->id, stream_id); + ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, ap_server_conf, APLOGNO(03358) + "h2_proxy_session(%s): recv data chunk for " + "unknown stream %d, ignored", + session->id, stream_id); return 0; } @@ -422,9 +422,9 @@ static ssize_t stream_data_read(nghttp2_ *data_flags = 0; stream = nghttp2_session_get_stream_user_data(ngh2, stream_id); if (!stream) { - ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, stream->r, APLOGNO(03361) - "h2_proxy_stream(%s): data_read, stream %d not found", - stream->session->id, stream_id); + ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, ap_server_conf, APLOGNO(03361) + "h2_proxy_stream(%s): data_read, stream %d not found", + stream->session->id, stream_id); return NGHTTP2_ERR_CALLBACK_FAILURE; }