httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yla...@apache.org
Subject svn commit: r1674703 - /httpd/httpd/branches/2.4.x/STATUS
Date Sun, 19 Apr 2015 22:14:35 GMT
Author: ylavic
Date: Sun Apr 19 22:14:34 2015
New Revision: 1674703

URL: http://svn.apache.org/r1674703
Log:
Comment on r1656259.

Modified:
    httpd/httpd/branches/2.4.x/STATUS

Modified: httpd/httpd/branches/2.4.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1674703&r1=1674702&r2=1674703&view=diff
==============================================================================
--- httpd/httpd/branches/2.4.x/STATUS (original)
+++ httpd/httpd/branches/2.4.x/STATUS Sun Apr 19 22:14:34 2015
@@ -230,6 +230,15 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
                the backend is available to rec' it. I understand the
                error described, but is the fix actually worth it (plus
                it seems to allow for a DDoS vector).
+     ylavic: It seems to me that the problem is real since we reuse the
+             connection before prefetching 16K (either controlled by the
+             client, or by an input filter), we currently always prefetch
+             these bytes already. Regarding performance I don't see any
+             difference (more cycles) compared with the current code.
+             However I think I failed to rebuild the header_brigade when
+             the proxy loop is retried (ping), so I need to rework this.
+             Do you think we'd better remove the prefetch, or maybe just
+             make it nonblocking (by default)?
 
   *) http: Make ap_die() robust against any HTTP error code and not modify
      response status (finally logged) when nothing is to be done. PR 56035.



Mime
View raw message