httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yla...@apache.org
Subject svn commit: r1674699 - /httpd/httpd/branches/2.4.x/STATUS
Date Sun, 19 Apr 2015 21:13:28 GMT
Author: ylavic
Date: Sun Apr 19 21:13:27 2015
New Revision: 1674699

URL: http://svn.apache.org/r1674699
Log:
Comment on r1674697.

Modified:
    httpd/httpd/branches/2.4.x/STATUS

Modified: httpd/httpd/branches/2.4.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1674699&r1=1674698&r2=1674699&view=diff
==============================================================================
--- httpd/httpd/branches/2.4.x/STATUS (original)
+++ httpd/httpd/branches/2.4.x/STATUS Sun Apr 19 21:13:27 2015
@@ -268,7 +268,8 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
   *) mpm_event: Allow for timer events duplicates.
      trunk patch: http://svn.apache.org/r1666468
                   http://svn.apache.org/r1666618
-     2.4.x patch: http://people.apache.org/~ylavic/httpd-2.4.x-event_timers_duplicates.patch
+                  http://svn.apache.org/r1674697
+     2.4.x patch: http://people.apache.org/~ylavic/httpd-2.4.x-event_timers_duplicates-v2.patch
      +1: ylavic, covener
      covener: what's the background here? What's currently broken?
      ylavic: I expected to find a common compare function for both MPMs event
@@ -286,6 +287,10 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
               same apr_time_t because the compare function would return 0 and insert_compare
               wouldn't let the duplicate in. post-patch, only two timer_event_t's with the
same
               address are equals.
+     ylavic: r1674697 (and v2) removes the debugging checks (not necessary in 2.4.x IMHO),
+             and add a comment about the compare function. As Eric explained above, the real
+             point is to return +1 instead of 0 there, so that duplicates are added after
+             each other (by order of insertion).
 
   *) mod_authz_core: Allow "Require expr" to work when the expression is quoted,
      as in an example in the doc.  PR 56235



Mime
View raw message