Return-Path: X-Original-To: apmail-httpd-cvs-archive@www.apache.org Delivered-To: apmail-httpd-cvs-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7A953C33C for ; Tue, 18 Nov 2014 13:54:46 +0000 (UTC) Received: (qmail 27950 invoked by uid 500); 18 Nov 2014 13:54:46 -0000 Delivered-To: apmail-httpd-cvs-archive@httpd.apache.org Received: (qmail 27883 invoked by uid 500); 18 Nov 2014 13:54:46 -0000 Mailing-List: contact cvs-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list cvs@httpd.apache.org Received: (qmail 27873 invoked by uid 99); 18 Nov 2014 13:54:46 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Nov 2014 13:54:46 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Nov 2014 13:54:45 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 1AB7123889CB; Tue, 18 Nov 2014 13:53:25 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1640345 - /httpd/httpd/trunk/modules/aaa/mod_authnz_fcgi.c Date: Tue, 18 Nov 2014 13:53:25 -0000 To: cvs@httpd.apache.org From: ylavic@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20141118135325.1AB7123889CB@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: ylavic Date: Tue Nov 18 13:53:24 2014 New Revision: 1640345 URL: http://svn.apache.org/r1640345 Log: mod_authnz_fcgi: we don't need to reserve an extra response header byte since r1640036. Modified: httpd/httpd/trunk/modules/aaa/mod_authnz_fcgi.c Modified: httpd/httpd/trunk/modules/aaa/mod_authnz_fcgi.c URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/aaa/mod_authnz_fcgi.c?rev=1640345&r1=1640344&r2=1640345&view=diff ============================================================================== --- httpd/httpd/trunk/modules/aaa/mod_authnz_fcgi.c (original) +++ httpd/httpd/trunk/modules/aaa/mod_authnz_fcgi.c Tue Nov 18 13:53:24 2014 @@ -491,7 +491,7 @@ static apr_status_t handle_response(cons apr_size_t readbuflen; apr_uint16_t clen; apr_uint16_t rid; - char readbuf[AP_IOBUFSIZE + 1]; + char readbuf[AP_IOBUFSIZE]; unsigned char farray[AP_FCGI_HEADER_LEN]; unsigned char plen; unsigned char type; @@ -527,8 +527,8 @@ static apr_status_t handle_response(cons recv_again: /* if we need to keep reading more of a record's content */ - if (clen > sizeof(readbuf) - 1) { - readbuflen = sizeof(readbuf) - 1; + if (clen > sizeof(readbuf)) { + readbuflen = sizeof(readbuf); } else { readbuflen = clen; } @@ -541,7 +541,6 @@ static apr_status_t handle_response(cons if (rv != APR_SUCCESS) { break; } - readbuf[readbuflen] = '\0'; } switch (type) {