httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yla...@apache.org
Subject svn commit: r1605210 - /httpd/httpd/branches/2.4.x/STATUS
Date Tue, 24 Jun 2014 22:02:10 GMT
Author: ylavic
Date: Tue Jun 24 22:02:10 2014
New Revision: 1605210

URL: http://svn.apache.org/r1605210
Log:
Comments.

Modified:
    httpd/httpd/branches/2.4.x/STATUS

Modified: httpd/httpd/branches/2.4.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1605210&r1=1605209&r2=1605210&view=diff
==============================================================================
--- httpd/httpd/branches/2.4.x/STATUS (original)
+++ httpd/httpd/branches/2.4.x/STATUS Tue Jun 24 22:02:10 2014
@@ -148,6 +148,14 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
      2.4.x patch: trunk works
      +1: ylavic
      covener: I did not look in depth, but is the preceding log message also bad?
+     ylavic: No, this concerns the next for (;; e = APR_BUCKET_NEXT(e)) iteration.
+             We could also s/apr_bucket_delete/APR_BUCKET_REMOVE/ instead, but
+             stripping some (unhandled) buckets from the source brigade does
+             not look correct to me either (brigade *to is to be consumed, but
+             *from is still living, the caller may want to reuse it, eg:
+             https://issues.apache.org/bugzilla/attachment.cgi?id=31686).
+             Should we?
+
 
    * mod_proxy_http: Avoid useless functions calls.
      trunk patch: http://svn.apache.org/r1572561
@@ -203,7 +211,8 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
                 re-allocated.
      trunk patch: http://svn.apache.org/r1604350
      2.4.x patch: http://people.apache.org/~covener/patches/httpd-2.4.x-event_sbh-race.diff
-     +1 covener, ylavic
+     +1 covener
+     ylavic: +1 with http://svn.apache.org/r1605067
 
 OTHER PROPOSALS
 



Mime
View raw message