httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yla...@apache.org
Subject svn commit: r1586125 - /httpd/httpd/branches/2.4.x/STATUS
Date Wed, 09 Apr 2014 20:13:53 GMT
Author: ylavic
Date: Wed Apr  9 20:13:53 2014
New Revision: 1586125

URL: http://svn.apache.org/r1586125
Log:
Vote and promote mod_auth_form fix (and remove duplicate).

Modified:
    httpd/httpd/branches/2.4.x/STATUS

Modified: httpd/httpd/branches/2.4.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1586125&r1=1586124&r2=1586125&view=diff
==============================================================================
--- httpd/httpd/branches/2.4.x/STATUS (original)
+++ httpd/httpd/branches/2.4.x/STATUS Wed Apr  9 20:13:53 2014
@@ -106,16 +106,18 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
   [ New proposals should be added at the end of the list ]
 
   * mod_auth_form: Make sure the optional functions are loaded even when
-    the AuthFormProvider isn't specified.
+    the AuthFormProvider isn't specified. PR 56351.
     trunk patch: https://svn.apache.org/r1531672
     2.4.x patch: trunk patch works, modulo CHANGES
-    +1: minfrin, jim
+    +1: minfrin, jim, ylavic
     -0 covener: does that mean just loading mod_auth_form w/o mod_request 
                 and mod_filter now causes a post-config failure?
     minfrin: It does, however it would only affect configs where mod_auth_form
              has been loaded but not used, as any attempt to use mod_auth_form
              without mod_request and mod_session present would cause the very
              same failure. Would a warning in the release notes be good enough?
+    ylavic: It fixes a runtime crash in this situation (PR 56351), I think
+            post_config (startup) is the best choice => +1
  
    * mod_slotmem_shm: Remove wonky and dangerous code that knows about APR
      internals. We work fine w/o it anyway at this stage.
@@ -251,14 +253,6 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
        The patch includes generated doc changes in order to carry eol-style.
      +1: trawick
 
-   * mod_auth_form: Make sure the optional functions are loaded even when
-                    the AuthFormProvider isn't specified. PR 56351.
-     Submitted/Commited by: minfrin
-     trunk patch: http://svn.apache.org/r1531672
-                  http://svn.apache.org/r1585435
-     2.4.x patch: trunk works (modulo CHANGES)
-     +1: ylavic
-
    * mod_proxy_fcgi: Fix for oddity with mod_proxy_fcgi which can bork
      response headers for mod_deflate-ed responses.
      trunk patch? http://svn.apache.org/r1585824



Mime
View raw message