httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j..@apache.org
Subject svn commit: r1500439 - /httpd/httpd/branches/2.4.x/STATUS
Date Sun, 07 Jul 2013 14:14:12 GMT
Author: jim
Date: Sun Jul  7 14:14:12 2013
New Revision: 1500439

URL: http://svn.apache.org/r1500439
Log:
comment and vote

Modified:
    httpd/httpd/branches/2.4.x/STATUS

Modified: httpd/httpd/branches/2.4.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1500439&r1=1500438&r2=1500439&view=diff
==============================================================================
--- httpd/httpd/branches/2.4.x/STATUS (original)
+++ httpd/httpd/branches/2.4.x/STATUS Sun Jul  7 14:14:12 2013
@@ -124,15 +124,23 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
                  http://svn.apache.org/viewvc?view=revision&revision=1482859
                  http://svn.apache.org/viewvc?view=revision&revision=1483190
                  http://svn.apache.org/viewvc?view=revision&revision=1484343
+                 http://svn.apache.org/viewvc?view=revision&revision=1500437
     2.4.x patch: trunk works, modulo CHANGES
     +1: jim, minfrin
     sf says:
-    - ap_proxy_sync_balancer() seems to use conf->pool in several
-      places, but only one place is protected by conf->mutex.
-      I don't think this is correct.
-      Also, I can't find any place where conf->mutex is initialized.
-    - ap_proxy_initialize_worker() is called from proxy_handler() with
-      conf->pool. I guess this should also be mutex protected?
+       - ap_proxy_sync_balancer() seems to use conf->pool in several
+         places, but only one place is protected by conf->mutex.
+         I don't think this is correct.
+         Also, I can't find any place where conf->mutex is initialized.
+    jj says:
+       - conf->pool is used in 2 places, both are now protected
+    sf says:
+       - ap_proxy_initialize_worker() is called from proxy_handler() with
+        conf->pool. I guess this should also be mutex protected?
+    jj says:
+       - it is: ap_proxy_initialize_worker() uses the mutex internally.
+         (line ~1735)
+    
 
   * mod_proxy_http: Make the proxy-interim-response environment variable
     effective by formally overriding origin server behaviour.
@@ -153,6 +161,8 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
                  http://svn.apache.org/r1498880
     2.4.x patch: http://people.apache.org/~sf/open_htaccess_hook.patch
     +1: sf, jorton, 
+    -0.5: jj: I would prefer if this sat in trunk for a few months first
+              to receive more testing.
 
   * mod_proxy: Connection header clearing issues
     trunk patch: https://svn.apache.org/viewvc?view=revision&revision=1481891



Mime
View raw message