httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j..@apache.org
Subject svn commit: r1494123 - /httpd/httpd/branches/2.4.x/STATUS
Date Tue, 18 Jun 2013 12:54:49 GMT
Author: jim
Date: Tue Jun 18 12:54:49 2013
New Revision: 1494123

URL: http://svn.apache.org/r1494123
Log:
sf doesn't like this so it won't be backported...
Oh well. Who sez useful stuff should be included?

Modified:
    httpd/httpd/branches/2.4.x/STATUS

Modified: httpd/httpd/branches/2.4.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1494123&r1=1494122&r2=1494123&view=diff
==============================================================================
--- httpd/httpd/branches/2.4.x/STATUS (original)
+++ httpd/httpd/branches/2.4.x/STATUS Tue Jun 18 12:54:49 2013
@@ -107,44 +107,6 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
     2.4.x patch: http://people.apache.org/~minfrin/httpd-mod_auth_basic-fake4.patch
     +1: minfrin, jim
 
-    * skiplist: Add skiplist functionality
-      trunk patches: https://svn.apache.org/r1411190
-                     https://svn.apache.org/r1411274
-                     https://svn.apache.org/r1411279
-                     https://svn.apache.org/r1411415
-                     https://svn.apache.org/r1411424
-                     https://svn.apache.org/r1411715
-                     https://svn.apache.org/r1415753
-                     https://svn.apache.org/r1451616
-                     https://svn.apache.org/r1451617
-                     https://svn.apache.org/r1451618
-                     https://svn.apache.org/r1451620
-                     https://svn.apache.org/r1451705
-                     https://svn.apache.org/r1452774
-                     https://svn.apache.org/r1463046
-      2.4.x patch: trunk patches work
-      +1: jim
-      sf comments (did not do a full review, though):
-      - The description of the proposal is misleading. The above commits add
-        the eventopt MPM. Do we really need another MPM in 2.4? Shouldn't we
-        merge the optimizations into event, instead?
-      - The skiplist API lacks documentation.
-      - ap_skiplist_alloc()/ap_skiplist_free() should at least have a free list
-        for sizeof(ap_skiplistnode) sized items. Otherwise it will leak lots of
-        memory.
-      - There does not seem to be any need for structs ap_skiplist and
-        ap_skiplistnode to be public. I would be in favor of making them
-        private to skiplist.c to allow changing implementation details later
-        without breaking compatibility.
-      - register_timed_callback is intended to be used from different threads.
-        The g_timer_skiplist_mtx mutex ensures that access to the skiplist
-        itself is serialized. However, the skiplist is created using pchild
-        and will allocate from that pool, but other use of pchild outside of
-        the skiplist is not protected by g_timer_skiplist_mtx. You must either
-        use a sub-pool or document why using pchild is save (I don't think it
-        is).
-
-
     * core, mod_ssl: Lift the restriction that prevents mod_ssl taking
       full advantage of the event MPM. Enable the ability for a module
       to reverse the sense of a poll event from a read to a write or vice



Mime
View raw message