Return-Path: X-Original-To: apmail-httpd-cvs-archive@www.apache.org Delivered-To: apmail-httpd-cvs-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8DBA2DC18 for ; Sun, 18 Nov 2012 13:21:30 +0000 (UTC) Received: (qmail 13412 invoked by uid 500); 18 Nov 2012 13:21:30 -0000 Delivered-To: apmail-httpd-cvs-archive@httpd.apache.org Received: (qmail 13356 invoked by uid 500); 18 Nov 2012 13:21:30 -0000 Mailing-List: contact cvs-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list cvs@httpd.apache.org Received: (qmail 13346 invoked by uid 99); 18 Nov 2012 13:21:30 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 18 Nov 2012 13:21:30 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 18 Nov 2012 13:21:27 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id C3E8223888EA; Sun, 18 Nov 2012 13:21:06 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1410885 - in /httpd/httpd/trunk/server/mpm: event/fdqueue.c eventopt/fdqueue.c Date: Sun, 18 Nov 2012 13:21:06 -0000 To: cvs@httpd.apache.org From: jim@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20121118132106.C3E8223888EA@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: jim Date: Sun Nov 18 13:21:05 2012 New Revision: 1410885 URL: http://svn.apache.org/viewvc?rev=1410885&view=rev Log: Document the check in open_logs() Modified: httpd/httpd/trunk/server/mpm/event/fdqueue.c httpd/httpd/trunk/server/mpm/eventopt/fdqueue.c Modified: httpd/httpd/trunk/server/mpm/event/fdqueue.c URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/mpm/event/fdqueue.c?rev=1410885&r1=1410884&r2=1410885&view=diff ============================================================================== --- httpd/httpd/trunk/server/mpm/event/fdqueue.c (original) +++ httpd/httpd/trunk/server/mpm/event/fdqueue.c Sun Nov 18 13:21:05 2012 @@ -103,6 +103,7 @@ apr_status_t ap_queue_info_set_idle(fd_q * TODO: The atomics expect unsigned whereas we're using signed. * Need to double check that they work as expected or else * rework how we determine blocked. + * UPDATE: Correct operation is performed during open_logs() */ prev_idlers = apr_atomic_inc32((apr_uint32_t *)&(queue_info->idlers)); Modified: httpd/httpd/trunk/server/mpm/eventopt/fdqueue.c URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/mpm/eventopt/fdqueue.c?rev=1410885&r1=1410884&r2=1410885&view=diff ============================================================================== --- httpd/httpd/trunk/server/mpm/eventopt/fdqueue.c (original) +++ httpd/httpd/trunk/server/mpm/eventopt/fdqueue.c Sun Nov 18 13:21:05 2012 @@ -103,6 +103,7 @@ apr_status_t ap_queue_info_set_idle(fd_q * TODO: The atomics expect unsigned whereas we're using signed. * Need to double check that they work as expected or else * rework how we determine blocked. + * UPDATE: Correct operation is performed during open_logs() */ prev_idlers = apr_atomic_inc32((apr_uint32_t *)&(queue_info->idlers));