Return-Path: X-Original-To: apmail-httpd-cvs-archive@www.apache.org Delivered-To: apmail-httpd-cvs-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C3756D181 for ; Tue, 13 Nov 2012 14:21:57 +0000 (UTC) Received: (qmail 19253 invoked by uid 500); 13 Nov 2012 14:21:57 -0000 Delivered-To: apmail-httpd-cvs-archive@httpd.apache.org Received: (qmail 19200 invoked by uid 500); 13 Nov 2012 14:21:57 -0000 Mailing-List: contact cvs-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list cvs@httpd.apache.org Received: (qmail 19185 invoked by uid 99); 13 Nov 2012 14:21:57 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Nov 2012 14:21:57 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Nov 2012 14:21:56 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 07F1D23888EA; Tue, 13 Nov 2012 14:21:36 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1408743 - in /httpd/httpd/branches/2.4.x: ./ CHANGES STATUS server/log.c Date: Tue, 13 Nov 2012 14:21:35 -0000 To: cvs@httpd.apache.org From: jim@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20121113142136.07F1D23888EA@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: jim Date: Tue Nov 13 14:21:34 2012 New Revision: 1408743 URL: http://svn.apache.org/viewvc?rev=1408743&view=rev Log: Merge r1399708 from trunk: only write the first len chars to syslog, as the buffer may have additional text added speculatively Submitted by: trawick Reviewed/backported by: jim Modified: httpd/httpd/branches/2.4.x/ (props changed) httpd/httpd/branches/2.4.x/CHANGES httpd/httpd/branches/2.4.x/STATUS httpd/httpd/branches/2.4.x/server/log.c Propchange: httpd/httpd/branches/2.4.x/ ------------------------------------------------------------------------------ Merged /httpd/httpd/trunk:r1399708 Modified: httpd/httpd/branches/2.4.x/CHANGES URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/CHANGES?rev=1408743&r1=1408742&r2=1408743&view=diff ============================================================================== --- httpd/httpd/branches/2.4.x/CHANGES [utf-8] (original) +++ httpd/httpd/branches/2.4.x/CHANGES [utf-8] Tue Nov 13 14:21:34 2012 @@ -2,6 +2,9 @@ Changes with Apache 2.4.4 + *) syslog logging: Remove stray ", referer" at the end of some messages. + [Jeff Trawick] + *) "Iterate" directives: Report an error if no arguments are provided. [Jeff Trawick] Modified: httpd/httpd/branches/2.4.x/STATUS URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1408743&r1=1408742&r2=1408743&view=diff ============================================================================== --- httpd/httpd/branches/2.4.x/STATUS (original) +++ httpd/httpd/branches/2.4.x/STATUS Tue Nov 13 14:21:34 2012 @@ -90,11 +90,6 @@ PATCHES ACCEPTED TO BACKPORT FROM TRUNK: [ start all new proposals below, under PATCHES PROPOSED. ] - * syslog logging: Remove stray ", referer" at the end of some messages. - trunk patch: http://svn.apache.org/viewvc?rev=1399708&view=rev - 2.4.x patch: trunk patch works: - +1: trawick, jim, jailletc36 - PATCHES PROPOSED TO BACKPORT FROM TRUNK: [ New proposals should be added at the end of the list ] Modified: httpd/httpd/branches/2.4.x/server/log.c URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/server/log.c?rev=1408743&r1=1408742&r2=1408743&view=diff ============================================================================== --- httpd/httpd/branches/2.4.x/server/log.c (original) +++ httpd/httpd/branches/2.4.x/server/log.c Tue Nov 13 14:21:34 2012 @@ -1087,7 +1087,8 @@ static void write_logline(char *errstr, } #ifdef HAVE_SYSLOG else { - syslog(level < LOG_PRIMASK ? level : APLOG_DEBUG, "%s", errstr); + syslog(level < LOG_PRIMASK ? level : APLOG_DEBUG, "%.*s", + (int)len, errstr); } #endif }