httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kbr...@apache.org
Subject svn commit: r1374517 - /httpd/httpd/branches/2.2.x/STATUS
Date Sat, 18 Aug 2012 06:46:19 GMT
Author: kbrand
Date: Sat Aug 18 06:46:19 2012
New Revision: 1374517

URL: http://svn.apache.org/viewvc?rev=1374517&view=rev
Log:
comment

Modified:
    httpd/httpd/branches/2.2.x/STATUS

Modified: httpd/httpd/branches/2.2.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?rev=1374517&r1=1374516&r2=1374517&view=diff
==============================================================================
--- httpd/httpd/branches/2.2.x/STATUS (original)
+++ httpd/httpd/branches/2.2.x/STATUS Sat Aug 18 06:46:19 2012
@@ -165,14 +165,19 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
     Backport version for 2.2.x of the patches above:
       http://people.apache.org/~wrowe/tls11-12-patch-2.2-kbrand-wrowe.1.patch
     +1: wrowe, 
-    kbrand: might want to add a reference to PR 53114 in CHANGES.
-              [wrowe] agreed, changed in patch .1
-            The #define HAVE_TLSV1_X stuff should go to ssl_toolkit_compat.h,
+    kbrand: The #define HAVE_TLSV1_X stuff should go to ssl_toolkit_compat.h,
               [wrowe] disagree, since that API was deprecated 
-            preferrably, and it would be good if mod_ssl.xml also includes
-            the change to the section about the SSLProtocol directive
-            (see r1222921).
-              [wrowe] missed that, thanks, changed in patch .1
+                kbrand: ok, won't insist on that, but as long as 2.2 still
+                        has ssl_toolkit_compat.h, I would prefer to see all
+                        OpenSSL version number checking etc. in a single place
+            patch .1 now has an issue with handling "SSLProtocol SSLv2"
+            or "SSLProtocol +SSLv2" (which are pretty nonsensical settings,
+            but nevertheless): ssl_cmd_protocol_parse will reject these
+            with "SSLv2 not supported by this version of OpenSSL", even
+            if OpenSSL hasn't been compiled with OPENSSL_NO_SSL2. I suggest
+            to drop the #ifndef around SSL_PROTOCOL_SSLV2 in ssl_private.h,
+            this should also make some of the other "#if[n]def OPENSSL_NO_SSL2"
+            encapsulations unnecessary.
     sf:
         - ssl_engine_init.c: misses two "ctx = SSL_CTX_new(method);" calls
           (or move the existing ones after the if blocks).



Mime
View raw message