httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s.@apache.org
Subject svn commit: r1325643 - in /httpd/mod_mbox/branches/convert-charsets/module-2.0: mbox_parse.c mbox_thread.c
Date Fri, 13 Apr 2012 08:08:55 GMT
Author: sf
Date: Fri Apr 13 08:08:55 2012
New Revision: 1325643

URL: http://svn.apache.org/viewvc?rev=1325643&view=rev
Log:
fix some warning about unused variables/initializations;
style impromvents

Modified:
    httpd/mod_mbox/branches/convert-charsets/module-2.0/mbox_parse.c
    httpd/mod_mbox/branches/convert-charsets/module-2.0/mbox_thread.c

Modified: httpd/mod_mbox/branches/convert-charsets/module-2.0/mbox_parse.c
URL: http://svn.apache.org/viewvc/httpd/mod_mbox/branches/convert-charsets/module-2.0/mbox_parse.c?rev=1325643&r1=1325642&r2=1325643&view=diff
==============================================================================
--- httpd/mod_mbox/branches/convert-charsets/module-2.0/mbox_parse.c (original)
+++ httpd/mod_mbox/branches/convert-charsets/module-2.0/mbox_parse.c Fri Apr 13 08:08:55 2012
@@ -68,10 +68,8 @@ typedef struct mb_dbm_data
  */
 void mbox_fillbuf(MBOX_BUFF *fb)
 {
-    int len;
-
     if (fb->fd) {
-        len = strlen(fb->b);
+        int len = strlen(fb->b);
 
         /* We are backed by a file descriptor.
          * Read a new set of characters in.
@@ -1058,13 +1056,13 @@ static apr_table_t *fetch_first_headers(
 {
     apr_status_t status;
     apr_table_t *table = NULL;
+    MBOX_BUFF b;
 #ifdef APR_HAS_MMAP
     apr_finfo_t fi;
+    const char *temp;
 #else
     char buf[HUGE_STRING_LEN + 1];
 #endif
-    MBOX_BUFF b;
-    const char *temp;
 
 #ifdef APR_HAS_MMAP
     status = apr_file_name_get(&temp, f);

Modified: httpd/mod_mbox/branches/convert-charsets/module-2.0/mbox_thread.c
URL: http://svn.apache.org/viewvc/httpd/mod_mbox/branches/convert-charsets/module-2.0/mbox_thread.c?rev=1325643&r1=1325642&r2=1325643&view=diff
==============================================================================
--- httpd/mod_mbox/branches/convert-charsets/module-2.0/mbox_thread.c (original)
+++ httpd/mod_mbox/branches/convert-charsets/module-2.0/mbox_thread.c Fri Apr 13 08:08:55
2012
@@ -59,13 +59,13 @@ static int is_reply(Message *m)
  */
 static char *strip_subject(apr_pool_t *p, Message *m)
 {
-    char *newVal = m->subject, *match = m->subject, *tmp = 0;
+    char *newVal, *match = m->subject, *tmp = NULL;
 
     /* Match the following cases: Re:, RE:, RE[1]:, Re: Re[2]: Re: */
     while (match && *match) {
         /* When we don't have a match, tmp contains the "real" subject. */
         tmp = newVal = match;
-        match = 0;
+        match = NULL;
         if (*newVal == 'R' && (*++newVal == 'e' || *newVal == 'E')) {
             /* Note to self.  In pure compressed syntax, the famous dangling
              * else occurs.  Oh, well. */



Mime
View raw message