httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wr...@apache.org
Subject svn commit: r1213454 - /httpd/mod_fcgid/trunk/modules/fcgid/fcgid_conf.c
Date Mon, 12 Dec 2011 21:52:28 GMT
Author: wrowe
Date: Mon Dec 12 21:52:27 2011
New Revision: 1213454

URL: http://svn.apache.org/viewvc?rev=1213454&view=rev
Log:
Solve latency/cogestion of resolving effective user file access rights
when no such info is desired, for config related filename stats. 

PR: 51560 
Submitted by: David Boyer <dave.apache yougeezer.co.uk>, wrowe

Modified:
    httpd/mod_fcgid/trunk/modules/fcgid/fcgid_conf.c

Modified: httpd/mod_fcgid/trunk/modules/fcgid/fcgid_conf.c
URL: http://svn.apache.org/viewvc/httpd/mod_fcgid/trunk/modules/fcgid/fcgid_conf.c?rev=1213454&r1=1213453&r2=1213454&view=diff
==============================================================================
--- httpd/mod_fcgid/trunk/modules/fcgid/fcgid_conf.c (original)
+++ httpd/mod_fcgid/trunk/modules/fcgid/fcgid_conf.c Mon Dec 12 21:52:27 2011
@@ -622,8 +622,8 @@ const char *set_authenticator_info(cmd_p
     apr_finfo_t finfo;
     fcgid_dir_conf *dirconfig = (fcgid_dir_conf *) config;
 
-    /* Is the wrapper exist? */
-    if ((rv = apr_stat(&finfo, authenticator, APR_FINFO_NORM,
+    /* Fetch only required file details inode + device */
+    if ((rv = apr_stat(&finfo, authenticator, APR_FINFO_IDENT,
                        cmd->temp_pool)) != APR_SUCCESS) {
         return missing_file_msg(cmd->pool, "Authenticator", authenticator, rv);
     }
@@ -671,8 +671,8 @@ const char *set_authorizer_info(cmd_parm
     apr_finfo_t finfo;
     fcgid_dir_conf *dirconfig = (fcgid_dir_conf *) config;
 
-    /* Is the wrapper exist? */
-    if ((rv = apr_stat(&finfo, authorizer, APR_FINFO_NORM,
+    /* Fetch only required file details inode + device */
+    if ((rv = apr_stat(&finfo, authorizer, APR_FINFO_IDENT,
                        cmd->temp_pool)) != APR_SUCCESS) {
         return missing_file_msg(cmd->pool, "Authorizer", authorizer, rv);
     }
@@ -720,8 +720,8 @@ const char *set_access_info(cmd_parms * 
     apr_finfo_t finfo;
     fcgid_dir_conf *dirconfig = (fcgid_dir_conf *) config;
 
-    /* Is the wrapper exist? */
-    if ((rv = apr_stat(&finfo, access, APR_FINFO_NORM,
+    /* Fetch only required file details inode + device */
+    if ((rv = apr_stat(&finfo, access, APR_FINFO_IDENT,
                        cmd->temp_pool)) != APR_SUCCESS) {
         return missing_file_msg(cmd->pool, "Access checker", access, rv);
     }
@@ -795,8 +795,8 @@ const char *set_wrapper_config(cmd_parms
     if (path == NULL || *path == '\0')
         return "Invalid wrapper config";
 
-    /* Does the wrapper exist? */
-    if ((rv = apr_stat(&finfo, path, APR_FINFO_NORM,
+    /* Fetch only required file details inode + device */
+    if ((rv = apr_stat(&finfo, path, APR_FINFO_IDENT,
                        cmd->temp_pool)) != APR_SUCCESS) {
         return missing_file_msg(cmd->pool, "Wrapper", path, rv);
     }
@@ -918,7 +918,8 @@ const char *set_cmd_options(cmd_parms *c
         return "A command must be specified for FcgidCmdOptions";
     }
 
-    rv = apr_stat(&finfo, cmdname, APR_FINFO_NORM, cmd->temp_pool);
+    /* Test only for file existence */
+    rv = apr_stat(&finfo, cmdname, APR_FINFO_MIN, cmd->temp_pool);
     if (rv != APR_SUCCESS) {
         return missing_file_msg(cmd->pool, "Command", cmdname, rv);
     }



Mime
View raw message