httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cove...@apache.org
Subject svn commit: r1157111 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_ldap.xml modules/ldap/util_ldap.c
Date Fri, 12 Aug 2011 13:56:55 GMT
Author: covener
Date: Fri Aug 12 13:56:54 2011
New Revision: 1157111

URL: http://svn.apache.org/viewvc?rev=1157111&view=rev
Log:
Accept LDAP_OPT_CONNECT_TIMEOUT as an alternative to LDAP_OPT_NETWORK_TIMEOUT.

An alternative on at least some IBM client libraries:

  http://publib.boulder.ibm.com/infocenter/tivihelp/v2r1/topic/com.ibm.IBMDS.doc/progref281.htm#opttimeout


Modified:
    httpd/httpd/trunk/CHANGES
    httpd/httpd/trunk/docs/manual/mod/mod_ldap.xml
    httpd/httpd/trunk/modules/ldap/util_ldap.c

Modified: httpd/httpd/trunk/CHANGES
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/CHANGES?rev=1157111&r1=1157110&r2=1157111&view=diff
==============================================================================
--- httpd/httpd/trunk/CHANGES [utf-8] (original)
+++ httpd/httpd/trunk/CHANGES [utf-8] Fri Aug 12 13:56:54 2011
@@ -1,6 +1,10 @@
                                                          -*- coding: utf-8 -*-
 Changes with Apache 2.3.15
 
+  *) mod_ldap: Enable LDAPConnectionTimeout for LDAP toolkits that have
+     LDAP_OPT_CONNECT_TIMEOUT instead of LDAP_OPT_NETWORK_TIMEOUT, such
+     as Tivoli Directory Server 6.3 and later. [Eric Covener]
+
   *) mod_ldap: Change default number of retries from 10 to 3, and add 
      an LDAPRetries and LDAPRetryDelay directives. [Eric Covener]
 

Modified: httpd/httpd/trunk/docs/manual/mod/mod_ldap.xml
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/docs/manual/mod/mod_ldap.xml?rev=1157111&r1=1157110&r2=1157111&view=diff
==============================================================================
--- httpd/httpd/trunk/docs/manual/mod/mod_ldap.xml (original)
+++ httpd/httpd/trunk/docs/manual/mod/mod_ldap.xml Fri Aug 12 13:56:54 2011
@@ -638,10 +638,10 @@ connection client certificates.</descrip
 <contextlist><context>server config</context></contextlist>
 
 <usage>
-    <p>This directive configures the LDAP_OPT_NETWORK_TIMEOUT option in the
-    underlying LDAP client library, when available.  This value typically 
-    controls how long the LDAP client library will wait for the TCP connection
-    to the LDAP server to complete.</p>
+    <p>This directive configures the LDAP_OPT_NETWORK_TIMEOUT (or LDAP_OPT_CONNECT_TIMEOUT)
+    option in the underlying LDAP client library, when available.  This value
+    typically controls how long the LDAP client library will wait for the TCP
+    connection to the LDAP server to complete.</p>
 
     <p> If a connection is not successful with the timeout period, either an error
will be 
     returned or the LDAP client library will attempt to connect to a secondary LDAP 
@@ -652,8 +652,9 @@ connection client certificates.</descrip
     server supports the LDAP_OPT_NETWORK_TIMEOUT option.</p>
 
     <note>LDAPConnectionTimeout is only available when the LDAP client library linked
-    with the server supports the LDAP_OPT_NETWORK_TIMEOUT option, and the
-    ultimate behavior is dictated entirely by the LDAP client library.
+    with the server supports the LDAP_OPT_NETWORK_TIMEOUT 
+    (or LDAP_OPT_CONNECT_TIMEOUT) option, and the ultimate behavior is 
+    dictated entirely by the LDAP client library.
     </note>
 </usage>
 </directivesynopsis>

Modified: httpd/httpd/trunk/modules/ldap/util_ldap.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/ldap/util_ldap.c?rev=1157111&r1=1157110&r2=1157111&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/ldap/util_ldap.c (original)
+++ httpd/httpd/trunk/modules/ldap/util_ldap.c Fri Aug 12 13:56:54 2011
@@ -66,6 +66,10 @@
 #define AP_LDAP_CONNPOOL_DEFAULT -1
 #define AP_LDAP_CONNPOOL_INFINITE -2
 
+#if !defined(LDAP_OPT_NETWORK_TIMEOUT) && defined(LDAP_OPT_CONNECT_TIMEOUT)
+#define LDAP_OPT_NETWORK_TIMEOUT LDAP_OPT_CONNECT_TIMEOUT
+#endif
+
 module AP_MODULE_DECLARE_DATA ldap_module;
 static const char *ldap_cache_mutex_type = "ldap-cache";
 static apr_status_t uldap_connection_unbind(void *param);



Mime
View raw message