httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s.@apache.org
Subject svn commit: r1131393 - in /httpd/httpd/trunk: ./ build/ include/ modules/aaa/ modules/ldap/
Date Sat, 04 Jun 2011 13:31:49 GMT
Author: sf
Date: Sat Jun  4 13:31:49 2011
New Revision: 1131393

URL: http://svn.apache.org/viewvc?rev=1131393&view=rev
Log:
Several fixes for the ap_ldap build logic. This should fix compilation
without --with-ldap.

Modified:
    httpd/httpd/trunk/build/find_ldap.m4
    httpd/httpd/trunk/configure.in
    httpd/httpd/trunk/include/ap_ldap.h.in
    httpd/httpd/trunk/include/ap_ldap_init.h
    httpd/httpd/trunk/include/ap_ldap_option.h
    httpd/httpd/trunk/include/ap_ldap_rebind.h
    httpd/httpd/trunk/include/ap_ldap_url.h
    httpd/httpd/trunk/include/util_ldap.h
    httpd/httpd/trunk/modules/aaa/config.m4
    httpd/httpd/trunk/modules/ldap/config.m4

Modified: httpd/httpd/trunk/build/find_ldap.m4
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/build/find_ldap.m4?rev=1131393&r1=1131392&r2=1131393&view=diff
==============================================================================
--- httpd/httpd/trunk/build/find_ldap.m4 (original)
+++ httpd/httpd/trunk/build/find_ldap.m4 Sat Jun  4 13:31:49 2011
@@ -39,6 +39,7 @@ AC_DEFUN([AP_FIND_LDAPLIB], [
         AC_CHECK_LIB(${ldaplib}, ldapssl_init, ap_has_ldapssl_init="1", , ${extralib})
         AC_CHECK_LIB(${ldaplib}, ldapssl_install_routines, ap_has_ldapssl_install_routines="1",
, ${extralib})
         ap_has_ldap="1";
+        AC_DEFINE(AP_HAS_LDAP, 1, [Defined if httpd is compiled with ldap support])
       ], , ${extralib})
   fi
 ])

Modified: httpd/httpd/trunk/configure.in
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/configure.in?rev=1131393&r1=1131392&r2=1131393&view=diff
==============================================================================
--- httpd/httpd/trunk/configure.in (original)
+++ httpd/httpd/trunk/configure.in Sat Jun  4 13:31:49 2011
@@ -446,6 +446,9 @@ fopen64
 dnl confirm that a void pointer is large enough to store a long integer
 APACHE_CHECK_VOID_PTR_LEN
 
+dnl check for LDAP support, needed by modules/aaa and modules/ldap
+AP_FIND_LDAP
+
 dnl ## Check for the tm_gmtoff field in struct tm to get the timezone diffs
 AC_CACHE_CHECK([for tm_gmtoff in struct tm], ac_cv_struct_tm_gmtoff,
 [AC_TRY_COMPILE([#include <sys/types.h>

Modified: httpd/httpd/trunk/include/ap_ldap.h.in
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/include/ap_ldap.h.in?rev=1131393&r1=1131392&r2=1131393&view=diff
==============================================================================
--- httpd/httpd/trunk/include/ap_ldap.h.in (original)
+++ httpd/httpd/trunk/include/ap_ldap.h.in Sat Jun  4 13:31:49 2011
@@ -51,9 +51,6 @@
 #define LDAP_DECLARE_DATA             __declspec(dllimport)
 #endif
 
-/* this will be defined if LDAP support was compiled into apr-util */
-#define AP_HAS_LDAP		  @ap_has_ldap@
-
 /* identify the LDAP toolkit used */
 #define AP_HAS_NETSCAPE_LDAPSDK  @ap_has_ldap_netscape@
 #define AP_HAS_SOLARIS_LDAPSDK   @ap_has_ldap_solaris@

Modified: httpd/httpd/trunk/include/ap_ldap_init.h
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/include/ap_ldap_init.h?rev=1131393&r1=1131392&r2=1131393&view=diff
==============================================================================
--- httpd/httpd/trunk/include/ap_ldap_init.h (original)
+++ httpd/httpd/trunk/include/ap_ldap_init.h Sat Jun  4 13:31:49 2011
@@ -26,10 +26,10 @@
  * @{
  */
 
-#include "ap_ldap.h"
-
 #if AP_HAS_LDAP
 
+#include "ap_ldap.h"
+
 #ifdef __cplusplus
 extern "C" {
 #endif /* __cplusplus */

Modified: httpd/httpd/trunk/include/ap_ldap_option.h
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/include/ap_ldap_option.h?rev=1131393&r1=1131392&r2=1131393&view=diff
==============================================================================
--- httpd/httpd/trunk/include/ap_ldap_option.h (original)
+++ httpd/httpd/trunk/include/ap_ldap_option.h Sat Jun  4 13:31:49 2011
@@ -26,10 +26,10 @@
  * @{
  */
 
-#include "ap_ldap.h"
-
 #if AP_HAS_LDAP
 
+#include "ap_ldap.h"
+
 #ifdef __cplusplus
 extern "C" {
 #endif /* __cplusplus */

Modified: httpd/httpd/trunk/include/ap_ldap_rebind.h
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/include/ap_ldap_rebind.h?rev=1131393&r1=1131392&r2=1131393&view=diff
==============================================================================
--- httpd/httpd/trunk/include/ap_ldap_rebind.h (original)
+++ httpd/httpd/trunk/include/ap_ldap_rebind.h Sat Jun  4 13:31:49 2011
@@ -25,23 +25,23 @@
  * @brief Apache LDAP library
  */
 
-#ifndef APU_LDAP_REBIND_H
-#define APU_LDAP_REBIND_H
+#ifndef AP_LDAP_REBIND_H
+#define AP_LDAP_REBIND_H
 
 /**
  * @addtogroup AP_Util_LDAP
  * @{
  **/
 
-#if defined(DOXYGEN)
-#include "ap_ldap.h"
-#endif
-
 /*
  * Handle the case when LDAP is enabled
  */
 #if AP_HAS_LDAP
 
+#if defined(DOXYGEN)
+#include "ap_ldap.h"
+#endif
+
 /**
  * LDAP initialize rebind lock
  *
@@ -94,5 +94,5 @@ LDAP_DECLARE(apr_status_t) ap_ldap_rebin
 
 /** @} */
 
-#endif /* APU_LDAP_REBIND_H */
+#endif /* AP_LDAP_REBIND_H */
 

Modified: httpd/httpd/trunk/include/ap_ldap_url.h
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/include/ap_ldap_url.h?rev=1131393&r1=1131392&r2=1131393&view=diff
==============================================================================
--- httpd/httpd/trunk/include/ap_ldap_url.h (original)
+++ httpd/httpd/trunk/include/ap_ldap_url.h Sat Jun  4 13:31:49 2011
@@ -26,15 +26,15 @@
  * @{
  */
 
-#if defined(DOXYGEN)
-#include "ap_ldap.h"
-#endif
-
 #if AP_HAS_LDAP
 
 #include "apu.h"
 #include "apr_pools.h"
 
+#if defined(DOXYGEN)
+#include "ap_ldap.h"
+#endif
+
 #ifdef __cplusplus
 extern "C" {
 #endif /* __cplusplus */

Modified: httpd/httpd/trunk/include/util_ldap.h
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/include/util_ldap.h?rev=1131393&r1=1131392&r2=1131393&view=diff
==============================================================================
--- httpd/httpd/trunk/include/util_ldap.h (original)
+++ httpd/httpd/trunk/include/util_ldap.h Sat Jun  4 13:31:49 2011
@@ -28,9 +28,6 @@
 #include "apr_thread_rwlock.h"
 #include "apr_tables.h"
 #include "apr_time.h"
-#include "ap_ldap.h"
-#include "ap_ldap_rebind.h"
-
 #if AP_HAS_MICROSOFT_LDAPSDK
 #define AP_LDAP_IS_SERVER_DOWN(s)                ((s) == LDAP_SERVER_DOWN \
                 ||(s) == LDAP_UNAVAILABLE)
@@ -43,9 +40,6 @@
 #include "apr_shm.h"
 #endif
 
-/* this whole thing disappears if LDAP is not enabled */
-#if AP_HAS_LDAP
-
 /* Apache header files */
 #include "ap_config.h"
 #include "httpd.h"
@@ -56,6 +50,12 @@
 #include "http_request.h"
 #include "apr_optional.h"
 
+/* this whole thing disappears if LDAP is not enabled */
+#if AP_HAS_LDAP
+
+#include "ap_ldap.h"
+#include "ap_ldap_rebind.h"
+
 #ifdef __cplusplus
 extern "C" {
 #endif

Modified: httpd/httpd/trunk/modules/aaa/config.m4
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/aaa/config.m4?rev=1131393&r1=1131392&r2=1131393&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/aaa/config.m4 (original)
+++ httpd/httpd/trunk/modules/aaa/config.m4 Sat Jun  4 13:31:49 2011
@@ -39,12 +39,11 @@ APACHE_MODULE(authz_core, core authoriza
 
 dnl LDAP authentication module. This module has both the authn and authz
 dnl modules in one, so as to share the LDAP server config directives.
-dnl XXX FIXME
 APACHE_MODULE(authnz_ldap, LDAP based authentication, , , no, [
-  if test -z "$apu_config" ; then
-      MOD_AUTHNZ_LDAP_LDADD="$LDADD_ldap"
+  if test "$ap_has_ldap" = "1" ; then
+    MOD_AUTHNZ_LDAP_LDADD="$LDADD_ldap"
   else
-      MOD_AUTHNZ_LDAP_LDADD="$LDADD_ldap"
+    enable_authnz_ldap=no
   fi
   AC_SUBST(MOD_AUTHNZ_LDAP_LDADD)
 ])

Modified: httpd/httpd/trunk/modules/ldap/config.m4
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/ldap/config.m4?rev=1131393&r1=1131392&r2=1131393&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/ldap/config.m4 (original)
+++ httpd/httpd/trunk/modules/ldap/config.m4 Sat Jun  4 13:31:49 2011
@@ -14,11 +14,10 @@ ap_ldap_url.lo dnl
 "
 
 APACHE_MODULE(ldap, LDAP caching and connection pooling services, $ldap_objects, , no, [
-  AP_FIND_LDAP
-  if test -z "$apu_config" ; then
-      MOD_LDAP_LDADD="$LDADD_ldap"
+  if test "$ap_has_ldap" = "1" ; then
+    MOD_LDAP_LDADD="$LDADD_ldap"
   else
-      MOD_LDAP_LDADD="$LDADD_ldap"
+    enable_ldap=no
   fi
   AC_SUBST(MOD_LDAP_LDADD)
 ])



Mime
View raw message