httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s.@apache.org
Subject svn commit: r1057920 - /httpd/httpd/trunk/server/request.c
Date Tue, 11 Jan 2011 23:10:07 GMT
Author: sf
Date: Tue Jan 11 23:10:06 2011
New Revision: 1057920

URL: http://svn.apache.org/viewvc?rev=1057920&view=rev
Log:
Save a useless check:
ap_get_request_note() cannot fail unless there is a bug somewhere and if
prep_walk_cache() returned NULL, we would just segfault later on.

Modified:
    httpd/httpd/trunk/server/request.c

Modified: httpd/httpd/trunk/server/request.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/request.c?rev=1057920&r1=1057919&r2=1057920&view=diff
==============================================================================
--- httpd/httpd/trunk/server/request.c (original)
+++ httpd/httpd/trunk/server/request.c Tue Jan 11 23:10:06 2011
@@ -333,9 +333,7 @@ static walk_cache_t *prep_walk_cache(apr
      * that exists; if not, then create a new walk cache.
      */
     note = ap_get_request_note(r, t);
-    if (!note) {
-        return NULL;
-    }
+    AP_DEBUG_ASSERT(note != NULL);
 
     copy_cache = prev_cache = *note;
     count = prev_cache ? (prev_cache->count + 1) : 0;



Mime
View raw message