httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From traw...@apache.org
Subject svn commit: r1030887 - in /httpd/mod_fcgid/trunk: CHANGES-FCGID docs/manual/mod/mod_fcgid.xml modules/fcgid/fcgid_conf.c
Date Thu, 04 Nov 2010 11:43:30 GMT
Author: trawick
Date: Thu Nov  4 11:43:30 2010
New Revision: 1030887

URL: http://svn.apache.org/viewvc?rev=1030887&view=rev
Log:
Change the default for FcgidMaxRequestLen from 1GB to 128K.

Modified:
    httpd/mod_fcgid/trunk/CHANGES-FCGID
    httpd/mod_fcgid/trunk/docs/manual/mod/mod_fcgid.xml
    httpd/mod_fcgid/trunk/modules/fcgid/fcgid_conf.c

Modified: httpd/mod_fcgid/trunk/CHANGES-FCGID
URL: http://svn.apache.org/viewvc/httpd/mod_fcgid/trunk/CHANGES-FCGID?rev=1030887&r1=1030886&r2=1030887&view=diff
==============================================================================
--- httpd/mod_fcgid/trunk/CHANGES-FCGID [utf8] (original)
+++ httpd/mod_fcgid/trunk/CHANGES-FCGID [utf8] Thu Nov  4 11:43:30 2010
@@ -1,6 +1,10 @@
                                                          -*- coding: utf-8 -*-
 Changes with mod_fcgid 2.3.6
 
+  *) Change the default for FcgidMaxRequestLen from 1GB to 128K.
+     Administrators should change this to an appropriate value based on
+     site requirements.  [Jeff Trawick]
+
   *) Allow FastCGI apps more time to exit at shutdown before being
      forcefully killed.  [Jeff Trawick]
 

Modified: httpd/mod_fcgid/trunk/docs/manual/mod/mod_fcgid.xml
URL: http://svn.apache.org/viewvc/httpd/mod_fcgid/trunk/docs/manual/mod/mod_fcgid.xml?rev=1030887&r1=1030886&r2=1030887&view=diff
==============================================================================
--- httpd/mod_fcgid/trunk/docs/manual/mod/mod_fcgid.xml (original)
+++ httpd/mod_fcgid/trunk/docs/manual/mod/mod_fcgid.xml Thu Nov  4 11:43:30 2010
@@ -879,11 +879,19 @@
     <name>FcgidMaxRequestLen</name>
     <description>maximum HTTP request length</description>
     <syntax>FcgidMaxRequestLen <em>bytes</em></syntax>
-    <default>FcgidMaxRequestLen 1073741824</default>
+    <default>FcgidMaxRequestLen 131072</default>
     <contextlist><context>server config</context> <context>virtual
host</context></contextlist>
     <usage>
       <p>If the size of the request body exceeds this amount, the
       request will fail with <code>500 Server Error</code>.</p>
+
+      <p>Administrators should change this to an appropriate value for their site based
+      on application requirements.</p>
+
+      <note type="warning"><title>Warning</title>
+      <p>Before 2.3.6, this defaulted to 1GB.  Most users of earlier versions should
+      use this directive to set a more reasonable limit.</p>
+      </note>
     </usage>
     <seealso><directive module="mod_fcgid">FcgidMaxRequestInMem</directive></seealso>
   </directivesynopsis>

Modified: httpd/mod_fcgid/trunk/modules/fcgid/fcgid_conf.c
URL: http://svn.apache.org/viewvc/httpd/mod_fcgid/trunk/modules/fcgid/fcgid_conf.c?rev=1030887&r1=1030886&r2=1030887&view=diff
==============================================================================
--- httpd/mod_fcgid/trunk/modules/fcgid/fcgid_conf.c (original)
+++ httpd/mod_fcgid/trunk/modules/fcgid/fcgid_conf.c Thu Nov  4 11:43:30 2010
@@ -52,8 +52,11 @@
 #define DEFAULT_IPC_COMM_TIMEOUT 40
 #define DEFAULT_OUTPUT_BUFFERSIZE 65536
 #define DEFAULT_MAX_REQUESTS_PER_PROCESS 0
-#define DEFAULT_MAX_REQUEST_LEN (1024*1024*1024)    /* 1G */
-#define DEFAULT_MAX_MEM_REQUEST_LEN (1024*64)   /* 64k */
+/* by default, allow spooling of request bodies up to
+ * 128k (first 64k in memory)
+ */
+#define DEFAULT_MAX_REQUEST_LEN (1024*128)
+#define DEFAULT_MAX_MEM_REQUEST_LEN (1024*64)
 #define DEFAULT_WRAPPER_KEY "ALL"
 #define WRAPPER_FLAG_VIRTUAL "virtual"
 



Mime
View raw message