httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From minf...@apache.org
Subject svn commit: r1023396 - /httpd/httpd/trunk/modules/cache/cache_storage.c
Date Sun, 17 Oct 2010 00:50:29 GMT
Author: minfrin
Date: Sun Oct 17 00:50:28 2010
New Revision: 1023396

URL: http://svn.apache.org/viewvc?rev=1023396&view=rev
Log:
Don't attempt to remove the existing conditional headers until we have
committed to adding our own.

Modified:
    httpd/httpd/trunk/modules/cache/cache_storage.c

Modified: httpd/httpd/trunk/modules/cache/cache_storage.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/cache/cache_storage.c?rev=1023396&r1=1023395&r2=1023396&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/cache/cache_storage.c (original)
+++ httpd/httpd/trunk/modules/cache/cache_storage.c Sun Oct 17 00:50:28 2010
@@ -313,30 +313,6 @@ int cache_select(cache_request_rec *cach
                     continue;
                 }
 
-                ap_log_error(APLOG_MARK, APLOG_DEBUG, APR_SUCCESS, r->server,
-                  "Cached response for %s isn't fresh.  Adding/replacing "
-                  "conditional request headers.", r->uri);
-
-                /* Make response into a conditional */
-                cache->stale_headers = apr_table_copy(r->pool,
-                                                      r->headers_in);
-
-                /* We can only revalidate with our own conditionals: remove the
-                 * conditions from the original request.
-                 */
-                apr_table_unset(r->headers_in, "If-Match");
-                apr_table_unset(r->headers_in, "If-Modified-Since");
-                apr_table_unset(r->headers_in, "If-None-Match");
-                apr_table_unset(r->headers_in, "If-Range");
-                apr_table_unset(r->headers_in, "If-Unmodified-Since");
-
-                /*
-                 * Do not do Range requests with our own conditionals: If
-                 * we get 304 the Range does not matter and otherwise the
-                 * entity changed and we want to have the complete entity
-                 */
-                apr_table_unset(r->headers_in, "Range");
-
                 etag = apr_table_get(h->resp_hdrs, "ETag");
                 lastmod = apr_table_get(h->resp_hdrs, "Last-Modified");
 
@@ -345,13 +321,37 @@ int cache_select(cache_request_rec *cach
                      * our own conditionals.
                      */
 
+                    ap_log_error(APLOG_MARK, APLOG_DEBUG, APR_SUCCESS, r->server,
+                            "Cached response for %s isn't fresh.  Adding/replacing "
+                            "conditional request headers.", r->uri);
+
+                    /* Make response into a conditional */
+                    cache->stale_headers = apr_table_copy(r->pool,
+                            r->headers_in);
+
+                    /* We can only revalidate with our own conditionals: remove the
+                     * conditions from the original request.
+                     */
+                    apr_table_unset(r->headers_in, "If-Match");
+                    apr_table_unset(r->headers_in, "If-Modified-Since");
+                    apr_table_unset(r->headers_in, "If-None-Match");
+                    apr_table_unset(r->headers_in, "If-Range");
+                    apr_table_unset(r->headers_in, "If-Unmodified-Since");
+
+                    /*
+                     * Do not do Range requests with our own conditionals: If
+                     * we get 304 the Range does not matter and otherwise the
+                     * entity changed and we want to have the complete entity
+                     */
+                    apr_table_unset(r->headers_in, "Range");
+
                     if (etag) {
                         apr_table_set(r->headers_in, "If-None-Match", etag);
                     }
 
                     if (lastmod) {
                         apr_table_set(r->headers_in, "If-Modified-Since",
-                                      lastmod);
+                                lastmod);
                     }
                     cache->stale_handle = h;
 
@@ -369,7 +369,7 @@ int cache_select(cache_request_rec *cach
                     irv = cache->provider->remove_url(h, r->pool);
                     if (irv != OK) {
                         ap_log_error(APLOG_MARK, APLOG_DEBUG, irv, r->server,
-                                     "cache: attempt to remove url from cache unsuccessful.");
+                                "cache: attempt to remove url from cache unsuccessful.");
                     }
 
                     /* try again with next cache type */



Mime
View raw message