httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rpl...@apache.org
Subject svn commit: r990746 - /httpd/httpd/trunk/modules/metadata/mod_remoteip.c
Date Mon, 30 Aug 2010 09:45:34 GMT
Author: rpluem
Date: Mon Aug 30 09:45:34 2010
New Revision: 990746

URL: http://svn.apache.org/viewvc?rev=990746&view=rev
Log:
* - temp_sa is already the correct pointer
  - use temp_sa instead of temp_sa_buff which is not a pointer

Pointed by: Andrew Skalski <voltara gmail.com>

Modified:
    httpd/httpd/trunk/modules/metadata/mod_remoteip.c

Modified: httpd/httpd/trunk/modules/metadata/mod_remoteip.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/metadata/mod_remoteip.c?rev=990746&r1=990745&r2=990746&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/metadata/mod_remoteip.c (original)
+++ httpd/httpd/trunk/modules/metadata/mod_remoteip.c Mon Aug 30 09:45:34 2010
@@ -260,7 +260,7 @@ static int remoteip_modify_connection(re
     remote = apr_pstrdup(r->pool, remote);
 
 #ifdef REMOTEIP_OPTIMIZED
-    memcpy(&temp_sa, c->remote_addr, sizeof(temp_sa));
+    memcpy(temp_sa, c->remote_addr, sizeof(*temp_sa));
     temp_sa->pool = r->pool;
 #else
     temp_sa = c->remote_addr;
@@ -310,7 +310,7 @@ static int remoteip_modify_connection(re
 #ifdef REMOTEIP_OPTIMIZED
         /* Decode remote_addr - sucks; apr_sockaddr_vars_set isn't 'public' */
         if (inet_pton(AF_INET, parse_remote, 
-                      &temp_sa_buff->sa.sin.sin_addr) > 0) {
+                      &temp_sa->sa.sin.sin_addr) > 0) {
             apr_sockaddr_vars_set(temp_sa, APR_INET, temp_sa.port);
         }
 #if APR_HAVE_IPV6



Mime
View raw message