httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pgollu...@apache.org
Subject svn commit: r983116 - /httpd/httpd/trunk/modules/filters/mod_reqtimeout.c
Date Fri, 06 Aug 2010 20:07:57 GMT
Author: pgollucci
Date: Fri Aug  6 20:07:57 2010
New Revision: 983116

URL: http://svn.apache.org/viewvc?rev=983116&view=rev
Log:
rv is never used which makes the whole if useless

Reported by:	clang static analyzer


Modified:
    httpd/httpd/trunk/modules/filters/mod_reqtimeout.c

Modified: httpd/httpd/trunk/modules/filters/mod_reqtimeout.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/filters/mod_reqtimeout.c?rev=983116&r1=983115&r2=983116&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/filters/mod_reqtimeout.c (original)
+++ httpd/httpd/trunk/modules/filters/mod_reqtimeout.c Fri Aug  6 20:07:57 2010
@@ -190,10 +190,7 @@ static apr_status_t reqtimeout_filter(ap
 #endif
 
             rv = ap_get_brigade(f->next, bb, AP_MODE_GETLINE, APR_NONBLOCK_READ, remaining);
-            if (APR_STATUS_IS_EAGAIN(rv)) {
-                rv = APR_SUCCESS;
-            }
-            else if (rv != APR_SUCCESS) {
+            if (rv != APR_SUCCESS) {
                 break;
             }
 



Mime
View raw message