httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From field...@apache.org
Subject svn commit: r965967 - /httpd/httpd/branches/2.2.x/STATUS
Date Tue, 20 Jul 2010 19:33:28 GMT
Author: fielding
Date: Tue Jul 20 19:33:28 2010
New Revision: 965967

URL: http://svn.apache.org/viewvc?rev=965967&view=rev
Log:
veto change to ap_rgetline_core(); should be reverted on truck as well

Modified:
    httpd/httpd/branches/2.2.x/STATUS

Modified: httpd/httpd/branches/2.2.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?rev=965967&r1=965966&r2=965967&view=diff
==============================================================================
--- httpd/httpd/branches/2.2.x/STATUS (original)
+++ httpd/httpd/branches/2.2.x/STATUS Tue Jul 20 19:33:28 2010
@@ -216,6 +216,12 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
      Trunk patch: http://svn.apache.org/viewvc?view=revision&revision=892678
      2.2 patch: trunk patch Works with offset.
      +1: niq
+     -1: fielding: this routine is hand-optimized for speed, and the
+         "solution" is to add an if (strlen(*s) < bytes_handled - 1)
+         to every single line read?  Seriously?  If we want to have
+         ap_rgetline_core() enforce validity, then we should be using a
+         stop character array and error on all control characters not
+         allowed by HTTP.
 
    * core: (re)-introduce -T commandline option to suppress documentroot
      check at startup



Mime
View raw message