httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From traw...@apache.org
Subject svn commit: r938987 - /httpd/mod_fcgid/trunk/modules/fcgid/fcgid_pm_unix.c
Date Wed, 28 Apr 2010 14:43:20 GMT
Author: trawick
Date: Wed Apr 28 14:43:19 2010
New Revision: 938987

URL: http://svn.apache.org/viewvc?rev=938987&view=rev
Log:
axe needless sanity checks in procmgr_post_spawn_cmd():

g_caughtSigTerm: that's set only in the process mgr, and this
                 function is called only from handler, so it
                 will never be set here

g_ap_write_pipe: that's set in the post-config hook, before
                 this function can be called from the handler

Modified:
    httpd/mod_fcgid/trunk/modules/fcgid/fcgid_pm_unix.c

Modified: httpd/mod_fcgid/trunk/modules/fcgid/fcgid_pm_unix.c
URL: http://svn.apache.org/viewvc/httpd/mod_fcgid/trunk/modules/fcgid/fcgid_pm_unix.c?rev=938987&r1=938986&r2=938987&view=diff
==============================================================================
--- httpd/mod_fcgid/trunk/modules/fcgid/fcgid_pm_unix.c (original)
+++ httpd/mod_fcgid/trunk/modules/fcgid/fcgid_pm_unix.c Wed Apr 28 14:43:19 2010
@@ -451,10 +451,6 @@ apr_status_t procmgr_post_spawn_cmd(fcgi
     char notifybyte;
     apr_size_t nbytes = sizeof(*command);
 
-    /* Sanity check first */
-    if (g_caughtSigTerm || !g_ap_write_pipe)
-        return APR_SUCCESS;
-
     /* Get the global mutex before posting the request */
     if ((rv = apr_global_mutex_lock(g_pipelock)) != APR_SUCCESS) {
         ap_log_rerror(APLOG_MARK, APLOG_EMERG, rv, r,



Mime
View raw message