httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rpl...@apache.org
Subject svn commit: r933919 - /httpd/httpd/trunk/modules/cache/mod_cache.c
Date Wed, 14 Apr 2010 12:00:11 GMT
Author: rpluem
Date: Wed Apr 14 12:00:11 2010
New Revision: 933919

URL: http://svn.apache.org/viewvc?rev=933919&view=rev
Log:
* Do NOT cache 206 responses in any case since we don't (yet) know how to
  cache partial responses. Fixes regression of r724093.

PR: 49113

Modified:
    httpd/httpd/trunk/modules/cache/mod_cache.c

Modified: httpd/httpd/trunk/modules/cache/mod_cache.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/cache/mod_cache.c?rev=933919&r1=933918&r2=933919&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/cache/mod_cache.c (original)
+++ httpd/httpd/trunk/modules/cache/mod_cache.c Wed Apr 14 12:00:11 2010
@@ -734,7 +734,8 @@ static int cache_save_filter(ap_filter_t
          * We include 304 Not Modified here too as this is the origin server
          * telling us to serve the cached copy.
          */
-        if (exps != NULL || cc_out != NULL) {
+        if ((exps != NULL || cc_out != NULL)
+            && r->status != HTTP_PARTIAL_CONTENT) {
             /* We are also allowed to cache any response given that it has a
              * valid Expires or Cache Control header. If we find a either of
              * those here,  we pass request through the rest of the tests. From
@@ -747,6 +748,9 @@ static int cache_save_filter(ap_filter_t
              * include the following: an Expires header (section 14.21); a
              * "max-age", "s-maxage",  "must-revalidate", "proxy-revalidate",
              * "public" or "private" cache-control directive (section 14.9).
+             *
+             * But do NOT store 206 responses in any case since we
+             * don't (yet) cache partial responses.
              */
         }
         else {



Mime
View raw message