Return-Path: Delivered-To: apmail-httpd-cvs-archive@www.apache.org Received: (qmail 52499 invoked from network); 9 Nov 2009 10:43:40 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 9 Nov 2009 10:43:40 -0000 Received: (qmail 17859 invoked by uid 500); 9 Nov 2009 10:43:40 -0000 Delivered-To: apmail-httpd-cvs-archive@httpd.apache.org Received: (qmail 17772 invoked by uid 500); 9 Nov 2009 10:43:40 -0000 Mailing-List: contact cvs-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list cvs@httpd.apache.org Received: (qmail 17763 invoked by uid 99); 9 Nov 2009 10:43:40 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Nov 2009 10:43:40 +0000 X-ASF-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Nov 2009 10:43:37 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 770BE23888D4; Mon, 9 Nov 2009 10:43:17 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r834013 - /httpd/httpd/trunk/modules/loggers/mod_log_config.c Date: Mon, 09 Nov 2009 10:43:17 -0000 To: cvs@httpd.apache.org From: sf@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20091109104317.770BE23888D4@eris.apache.org> Author: sf Date: Mon Nov 9 10:43:16 2009 New Revision: 834013 URL: http://svn.apache.org/viewvc?rev=834013&view=rev Log: Also remove trailing whitespace in the value Modified: httpd/httpd/trunk/modules/loggers/mod_log_config.c Modified: httpd/httpd/trunk/modules/loggers/mod_log_config.c URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/loggers/mod_log_config.c?rev=834013&r1=834012&r2=834013&view=diff ============================================================================== --- httpd/httpd/trunk/modules/loggers/mod_log_config.c (original) +++ httpd/httpd/trunk/modules/loggers/mod_log_config.c Mon Nov 9 10:43:16 2009 @@ -502,7 +502,7 @@ * This supports Netscape version 0 cookies while being tolerant to * some properties of RFC2109/2965 version 1 cookies: * - case-insensitive match of cookie names - * - white space around the '=' + * - white space between the tokens * It does not support the following version 1 features: * - quoted strings as cookie values * - commas to separate cookies @@ -518,7 +518,14 @@ apr_collapse_spaces(name, name); if (!strcasecmp(name, a) && (value = apr_strtok(NULL, "=", &last2))) { - value += strspn(value, " \t"); /* Move past WS */ + char *last; + value += strspn(value, " \t"); /* Move past leading WS */ + last = value + strlen(value); + while (last >= value && apr_isspace(*last)) { + *last = '\0'; + --last; + } + return ap_escape_logitem(r->pool, value); } cookies = NULL;