Mailing-List: contact cvs-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r833883 -
 /httpd/mod_fcgid/trunk/modules/fcgid/fcgid_bridge.c
Date: Sun, 08 Nov 2009 15:15:29 -0000
To: cvs@httpd.apache.org
From: pqf@apache.org
Message-Id: <20091108151530.29FAE23888C2@eris.apache.org>

Author: pqf
Date: Sun Nov  8 15:15:28 2009
New Revision: 833883

URL: http://svn.apache.org/viewvc?rev=833883&view=rev
Log:
procnode->requests_handled does not increase in some cases

Modified:
    httpd/mod_fcgid/trunk/modules/fcgid/fcgid_bridge.c

Modified: httpd/mod_fcgid/trunk/modules/fcgid/fcgid_bridge.c
URL: http://svn.apache.org/viewvc/httpd/mod_fcgid/trunk/modules/fcgid/fcgid_bridge.c?rev=833883&r1=833882&r2=833883&view=diff
==============================================================================
--- httpd/mod_fcgid/trunk/modules/fcgid/fcgid_bridge.c (original)
+++ httpd/mod_fcgid/trunk/modules/fcgid/fcgid_bridge.c Sun Nov  8 15:15:28 2009
@@ -171,6 +171,7 @@
     }
 
     proc_close_ipc(&ctx->ipc);
+    ++ctx->procnode->requests_handled;
 
     if (ctx->procnode) {
         /* FIXME See BZ #47483 */
@@ -196,7 +197,7 @@
             return_procnode(r, ctx->procnode,
                             1 /* communication error */ );
         } else if (ctx->procnode->cmdopts.max_requests_per_process
-                   && ++ctx->procnode->requests_handled >=
+                   && ctx->procnode->requests_handled >=
                    ctx->procnode->cmdopts.max_requests_per_process) {
             ctx->procnode->diewhy = FCGID_DIE_LIFETIME_EXPIRED;
             return_procnode(r, ctx->procnode,
@@ -448,12 +449,11 @@
     int seen_eos;
 
     /* Stdin header and body */
-    /* XXX HACK: I have to read all the request into memory before sending it 
+    /* I have to read all the request into memory before sending it 
        to fastcgi application server, this prevents slow clients from 
        keeping the server in processing too long. 
        But sometimes it's not acceptable (think about uploading a large attachment)
-       file_bucket is a better choice in this case...
-       To do, or not to do, that is the question ^_^
+       Request will be stored in tmp file if the size larger than max_mem_request_len
      */
     seen_eos = 0;
     do {