Return-Path: Delivered-To: apmail-httpd-cvs-archive@www.apache.org Received: (qmail 52482 invoked from network); 27 Oct 2009 11:12:53 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 27 Oct 2009 11:12:53 -0000 Received: (qmail 96705 invoked by uid 500); 27 Oct 2009 11:12:53 -0000 Delivered-To: apmail-httpd-cvs-archive@httpd.apache.org Received: (qmail 96618 invoked by uid 500); 27 Oct 2009 11:12:52 -0000 Mailing-List: contact cvs-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list cvs@httpd.apache.org Received: (qmail 96606 invoked by uid 99); 27 Oct 2009 11:12:52 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Oct 2009 11:12:52 +0000 X-ASF-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Oct 2009 11:12:47 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 9DA7223888E3; Tue, 27 Oct 2009 11:12:27 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r830132 - /httpd/mod_fcgid/trunk/modules/fcgid/fcgid_pm_win.c Date: Tue, 27 Oct 2009 11:12:27 -0000 To: cvs@httpd.apache.org From: trawick@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20091027111227.9DA7223888E3@eris.apache.org> Author: trawick Date: Tue Oct 27 11:12:27 2009 New Revision: 830132 URL: http://svn.apache.org/viewvc?rev=830132&view=rev Log: release mutex on error path instead of trying to obtain it again Modified: httpd/mod_fcgid/trunk/modules/fcgid/fcgid_pm_win.c Modified: httpd/mod_fcgid/trunk/modules/fcgid/fcgid_pm_win.c URL: http://svn.apache.org/viewvc/httpd/mod_fcgid/trunk/modules/fcgid/fcgid_pm_win.c?rev=830132&r1=830131&r2=830132&view=diff ============================================================================== --- httpd/mod_fcgid/trunk/modules/fcgid/fcgid_pm_win.c (original) +++ httpd/mod_fcgid/trunk/modules/fcgid/fcgid_pm_win.c Tue Oct 27 11:12:27 2009 @@ -193,7 +193,7 @@ if ((rv = apr_queue_pop(g_notifyqueue, ¬ifybyte)) != APR_SUCCESS) { - apr_thread_mutex_lock(g_reqlock); + apr_thread_mutex_unlock(g_reqlock); ap_log_rerror(APLOG_MARK, APLOG_EMERG, rv, r, "mod_fcgid: can't pop notify message"); return rv;