Author: covener
Date: Thu Aug 27 03:22:37 2009
New Revision: 808272
URL: http://svn.apache.org/viewvc?rev=808272&view=rev
Log:
Don't trigger "need AuthType to note auth failure" when mod_fcgid FastCGIAccessChecker
is returning an access error w/o authn configured. access checkers don't call
ap_note_auth_failure().
Doesn't apply to Authenticator or Authorizer.
[warn] [client 127.0.0.1] mod_fcgid: user (null) access check failed, status 401, URI /fcgid/protected.html
[error] [client 127.0.0.1] need AuthType to note auth failure: /fcgid/protected.html
Modified:
httpd/mod_fcgid/trunk/CHANGES-FCGID
httpd/mod_fcgid/trunk/modules/fcgid/mod_fcgid.c
Modified: httpd/mod_fcgid/trunk/CHANGES-FCGID
URL: http://svn.apache.org/viewvc/httpd/mod_fcgid/trunk/CHANGES-FCGID?rev=808272&r1=808271&r2=808272&view=diff
==============================================================================
--- httpd/mod_fcgid/trunk/CHANGES-FCGID [utf8] (original)
+++ httpd/mod_fcgid/trunk/CHANGES-FCGID [utf8] Thu Aug 27 03:22:37 2009
@@ -1,6 +1,10 @@
-*- coding: utf-8 -*-
Changes with mod_fcgid 2.3.1
+ *) Suppress "need AuthType to note auth failure" error-level messages when a
+ FastCGIAccessChecker fails without any other kind of authentication
+ (Basic, Digest) configured. [Eric Covener]
+
*) Complete the unix port to 2.3-dev trunk. [William Rowe]
*) Provide a default, mandatory environment as with mod_cgi (with the
Modified: httpd/mod_fcgid/trunk/modules/fcgid/mod_fcgid.c
URL: http://svn.apache.org/viewvc/httpd/mod_fcgid/trunk/modules/fcgid/mod_fcgid.c?rev=808272&r1=808271&r2=808272&view=diff
==============================================================================
--- httpd/mod_fcgid/trunk/modules/fcgid/mod_fcgid.c (original)
+++ httpd/mod_fcgid/trunk/modules/fcgid/mod_fcgid.c Thu Aug 27 03:22:37 2009
@@ -505,7 +505,6 @@
if (!authoritative)
return DECLINED;
else {
- ap_note_basic_auth_failure(r);
return (res == OK) ? HTTP_UNAUTHORIZED : res;
}
}
|