Return-Path: Delivered-To: apmail-httpd-cvs-archive@www.apache.org Received: (qmail 75925 invoked from network); 2 Jan 2009 19:01:25 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 2 Jan 2009 19:01:25 -0000 Received: (qmail 81298 invoked by uid 500); 2 Jan 2009 19:01:24 -0000 Delivered-To: apmail-httpd-cvs-archive@httpd.apache.org Received: (qmail 81280 invoked by uid 500); 2 Jan 2009 19:01:24 -0000 Mailing-List: contact cvs-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list cvs@httpd.apache.org Received: (qmail 81271 invoked by uid 99); 2 Jan 2009 19:01:24 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Jan 2009 11:01:24 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Jan 2009 19:01:23 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 08A682388995; Fri, 2 Jan 2009 11:01:02 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r730815 - /httpd/httpd/trunk/server/util_script.c Date: Fri, 02 Jan 2009 19:01:01 -0000 To: cvs@httpd.apache.org From: wrowe@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090102190102.08A682388995@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: wrowe Date: Fri Jan 2 11:01:01 2009 New Revision: 730815 URL: http://svn.apache.org/viewvc?rev=730815&view=rev Log: document some nonsense it may be sizeof off_t > sizeof size_t. Modified: httpd/httpd/trunk/server/util_script.c Modified: httpd/httpd/trunk/server/util_script.c URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/util_script.c?rev=730815&r1=730814&r2=730815&view=diff ============================================================================== --- httpd/httpd/trunk/server/util_script.c (original) +++ httpd/httpd/trunk/server/util_script.c Fri Jan 2 11:01:01 2009 @@ -816,6 +816,9 @@ if (!rv) { apr_size_t total; + /* XXX where's our test that len fits in memory??? + * theoretically can be a large file > ram space + */ buffer = apr_palloc(tpool, len+1); total = len+1;