httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pque...@apache.org
Subject svn commit: r722398 - /httpd/httpd/trunk/modules/cluster/mod_heartbeat.c
Date Tue, 02 Dec 2008 08:11:18 GMT
Author: pquerna
Date: Tue Dec  2 00:11:17 2008
New Revision: 722398

URL: http://svn.apache.org/viewvc?rev=722398&view=rev
Log:
Don't do anything by defautl if we haven't been configured.

Modified:
    httpd/httpd/trunk/modules/cluster/mod_heartbeat.c

Modified: httpd/httpd/trunk/modules/cluster/mod_heartbeat.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/cluster/mod_heartbeat.c?rev=722398&r1=722397&r2=722398&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/cluster/mod_heartbeat.c (original)
+++ httpd/httpd/trunk/modules/cluster/mod_heartbeat.c Tue Dec  2 00:11:17 2008
@@ -211,11 +211,11 @@
 {
     hb_ctx_t *ctx = ap_get_module_config(s->module_config, &heartbeat_module);
 
-    apr_proc_mutex_child_init(&ctx->mutex, ctx->mutex_path, p);
-
-    ctx->status = -1;
-
     if (ctx->active) {
+        apr_proc_mutex_child_init(&ctx->mutex, ctx->mutex_path, p);
+        
+        ctx->status = -1;
+        
         start_hb_worker(p, ctx);
         if (ctx->status != 0) {
             ap_log_error(APLOG_MARK, APLOG_CRIT, 0, s,
@@ -236,6 +236,10 @@
     ap_mpm_query(AP_MPMQ_HARD_LIMIT_THREADS, &ctx->thread_limit);
     ap_mpm_query(AP_MPMQ_HARD_LIMIT_DAEMONS, &ctx->server_limit);
 
+    if (!ctx->active) {
+        return OK;
+    }
+
     rv = apr_proc_mutex_create(&ctx->mutex, ctx->mutex_path,
 #if APR_HAS_FCNTL_SERIALIZE
                                APR_LOCK_FCNTL,
@@ -266,11 +270,7 @@
 
 static void *hb_create_config(apr_pool_t *p, server_rec *s)
 {
-    hb_ctx_t *cfg = (hb_ctx_t *) apr_palloc(p, sizeof(hb_ctx_t));
-
-    cfg->active = 0;
-    cfg->thread_limit = 0;
-    cfg->server_limit = 0;
+    hb_ctx_t *cfg = (hb_ctx_t *) apr_pcalloc(p, sizeof(hb_ctx_t));
 
     return cfg;
 }
@@ -294,7 +294,12 @@
         return err;
     }
 
-    ctx->active = 1;
+    if (!ctx->active) {
+        ctx->active = 1;
+    }
+    else {
+        return "HeartbeatAddress: May only be specified once.";
+    }
 
     rv = apr_parse_addr_port(&host_str, &scope_id, &port, addr, p);
 



Mime
View raw message