httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rpl...@apache.org
Subject svn commit: r704751 - /httpd/httpd/branches/2.2.x/STATUS
Date Wed, 15 Oct 2008 00:22:04 GMT
Author: rpluem
Date: Tue Oct 14 17:22:04 2008
New Revision: 704751

URL: http://svn.apache.org/viewvc?rev=704751&view=rev
Log:
* Veto a backport

Modified:
    httpd/httpd/branches/2.2.x/STATUS

Modified: httpd/httpd/branches/2.2.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?rev=704751&r1=704750&r2=704751&view=diff
==============================================================================
--- httpd/httpd/branches/2.2.x/STATUS (original)
+++ httpd/httpd/branches/2.2.x/STATUS Tue Oct 14 17:22:04 2008
@@ -124,6 +124,16 @@
      Backport version for 2.2.x of patch:
         Trunk version of patch works
      +1: jim
+     -1: rpluem: apr_socket_timeout_set already sets the socket to non-blocking
+         mode because the timeout of the socket is -1 after creation. A further
+         call to apr_socket_timeout_set (after the connect call does not do
+         this, because the old and the new timeout are >=0).
+         The further code expects the socket to be in non-blocking mode, otherwise
+         we have regressions with ssl. This can be notified by running t/ssl/proxy
+         which runs much much slower with the patch applied. This does not happen
+         on trunk because the socket is set back to non blocking by the core
+         output filter (async write completion).
+         So r703998 should be also reverted on trunk.
 
    * mod_rewrite: Export and install the mod_rewrite.h header to ensure the
      optional rewrite_mapfunc_t and ap_register_rewrite_mapfunc functions are



Mime
View raw message