httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j..@apache.org
Subject svn commit: r686786 - /httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c
Date Mon, 18 Aug 2008 15:30:23 GMT
Author: jim
Date: Mon Aug 18 08:30:23 2008
New Revision: 686786

URL: http://svn.apache.org/viewvc?rev=686786&view=rev
Log:
Add comment on why the cast is safe and does not result
in lost info.

Modified:
    httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c

Modified: httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c?rev=686786&r1=686785&r2=686786&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c (original)
+++ httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c Mon Aug 18 08:30:23 2008
@@ -329,6 +329,7 @@
 
         envlen += vallen;
 
+	/* The cast of bodylen is safe since FCGI_MAX_ENV_SIZE is for sure an int */
         if (envlen > FCGI_MAX_ENV_SIZE) {
             ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r,
                           "proxy: FCGI: truncating environment to %d bytes and %d elements",



Mime
View raw message