httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From traw...@apache.org
Subject svn commit: r683626 - in /httpd/httpd/trunk: CHANGES modules/dav/fs/repos.c
Date Thu, 07 Aug 2008 15:12:00 GMT
Author: trawick
Date: Thu Aug  7 08:12:00 2008
New Revision: 683626

URL: http://svn.apache.org/viewvc?rev=683626&view=rev
Log:
mod_dav_fs: Retrieve minimal system information about directory 
entries when walking a DAV fs, resolving a performance degradation on
Windows.

PR: 45464

Modified:
    httpd/httpd/trunk/CHANGES
    httpd/httpd/trunk/modules/dav/fs/repos.c

Modified: httpd/httpd/trunk/CHANGES
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/CHANGES?rev=683626&r1=683625&r2=683626&view=diff
==============================================================================
--- httpd/httpd/trunk/CHANGES [utf-8] (original)
+++ httpd/httpd/trunk/CHANGES [utf-8] Thu Aug  7 08:12:00 2008
@@ -2,6 +2,10 @@
 Changes with Apache 2.3.0
 [ When backported to 2.2.x, remove entry from this file ]
 
+  *) mod_dav_fs: Retrieve minimal system information about directory 
+     entries when walking a DAV fs, resolving a performance degradation on 
+     Windows.  PR 45464.  [Jeff Trawick]
+
   *) mod_cgid: Pass along empty command line arguments from an ISINDEX
      query that has consecutive '+' characters in the QUERY_STRING, 
      matching the behavior of mod_cgi.

Modified: httpd/httpd/trunk/modules/dav/fs/repos.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/dav/fs/repos.c?rev=683626&r1=683625&r2=683626&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/dav/fs/repos.c (original)
+++ httpd/httpd/trunk/modules/dav/fs/repos.c Thu Aug  7 08:12:00 2008
@@ -1475,10 +1475,8 @@
         /* append this file onto the path buffer (copy null term) */
         dav_buffer_place_mem(pool, &fsctx->path1, dirent.name, len + 1, 0);
 
-
-        /* ### Optimize me, dirent can give us what we need! */
         status = apr_stat(&fsctx->info1.finfo, fsctx->path1.buf,
-                          APR_FINFO_NORM | APR_FINFO_LINK, pool);
+                          APR_FINFO_TYPE | APR_FINFO_LINK, pool);
         if (status != APR_SUCCESS && status != APR_INCOMPLETE) {
             /* woah! where'd it go? */
             /* ### should have a better error here */



Mime
View raw message