httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject svn commit: r655001 - /httpd/httpd/branches/2.2.x/STATUS
Date Sat, 10 May 2008 01:15:06 GMT
Author: chrisd
Date: Fri May  9 18:15:06 2008
New Revision: 655001

cast a vote, with explanation


Modified: httpd/httpd/branches/2.2.x/STATUS
--- httpd/httpd/branches/2.2.x/STATUS (original)
+++ httpd/httpd/branches/2.2.x/STATUS Fri May  9 18:15:06 2008
@@ -132,7 +132,7 @@

       Backport version of 2.2.x of patch:
          Trunk version works (minus CHANGES conflict)
-    +1: niq, wrowe [with chrisd's suggested change below]
+    +1: niq, wrowe [with chrisd's suggested change below], chrisd [as-is]
     chrisd says: The patch seems to address the issues in the PR.
                  My only concern would be that the ap_location_walk() call
                  (the second one) expects r->uri.  I'm fairly sure that
@@ -145,6 +145,15 @@
                  r->uri = "" (but not NULL, I think ...); we might as
                  well bypass <Location> checks on these, and also handle
                  any external modules that might try passing r->uri as NULL.
+    chrisd says: I did some testing with NULL and empty r->uri values
+                 and concluded this change appears to be OK as it stands.
+                 If r->uri is NULL then the preceding call to
+                 ap_getparents() crashes, so no functional modules
+                 could be doing this.  As for empty r->uri values,
+                 <Location ""> will match against these (along with
+                 everything else), so we shouldn't bypass them.
+                 (Such <Location> usage may not be what's expected, but
+                 it works and could be in use by someone.)
  * Support chroot on unix-family platforms
    PR 43596

View raw message