httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From traw...@apache.org
Subject svn commit: r651370 - /httpd/httpd/branches/2.2.x/STATUS
Date Thu, 24 Apr 2008 19:50:07 GMT
Author: trawick
Date: Thu Apr 24 12:49:59 2008
New Revision: 651370

URL: http://svn.apache.org/viewvc?rev=651370&view=rev
Log:
return -ENOGROK

Modified:
    httpd/httpd/branches/2.2.x/STATUS

Modified: httpd/httpd/branches/2.2.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?rev=651370&r1=651369&r2=651370&view=diff
==============================================================================
--- httpd/httpd/branches/2.2.x/STATUS (original)
+++ httpd/httpd/branches/2.2.x/STATUS Thu Apr 24 12:49:59 2008
@@ -204,6 +204,16 @@
    Backport version for 2.2.x of patch:
        http://people.apache.org/~covener/2.2.x-pr44560.diff
    +1 covener, niq
+   trawick: I don't understand the API for the affected array.
+     Consider uldap_cache_getuserdn():  
+     Before this change, we returned a new list of ptrs to strings,
+     with a NULL ptr signifying the end of the list.  (Yes, we messed
+     up and could miss some of the strings.)
+     After this change, we return a new list of ptrs to strings,
+     of indeterminate length since NULL pointers are scattered 
+     through the array.  So how does the caller know how to walk
+     through the list? (It seems that we need need to allocate numvals+1,
+     then store in (*retvals)[j++] when vals[i] != NULL.)
 
  * mod_headers: Add merge option to avoid duplicate values within
    the same header.



Mime
View raw message