httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rpl...@apache.org
Subject svn commit: r614661 - in /httpd/httpd/branches/2.2.x: STATUS modules/ldap/util_ldap.c modules/loggers/mod_log_forensic.c
Date Wed, 23 Jan 2008 20:54:17 GMT
Author: rpluem
Date: Wed Jan 23 12:54:16 2008
New Revision: 614661

URL: http://svn.apache.org/viewvc?rev=614661&view=rev
Log:
Merge r599651, r608508, r611376 from trunk:

Get rid of some compiler warnings.

* Silence a compiler warning by using the correct format.

* Hex pids are bogus anyway and on environments with APR_PID_T_FMT d this
  breaks and print x.

Submitted by: rpluem
Reviewed by: rpluem, covener, trawick

Modified:
    httpd/httpd/branches/2.2.x/STATUS
    httpd/httpd/branches/2.2.x/modules/ldap/util_ldap.c
    httpd/httpd/branches/2.2.x/modules/loggers/mod_log_forensic.c

Modified: httpd/httpd/branches/2.2.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?rev=614661&r1=614660&r2=614661&view=diff
==============================================================================
--- httpd/httpd/branches/2.2.x/STATUS (original)
+++ httpd/httpd/branches/2.2.x/STATUS Wed Jan 23 12:54:16 2008
@@ -88,15 +88,6 @@
         http://people.apache.org/~trawick/r529626_to_22x.txt
       +1: trawick, rpluem, covener
 
-  * various modules: Silence some compiler warnings
-      Trunk version of patch:
-         http://svn.apache.org/viewvc?rev=599651&view=rev
-         http://svn.apache.org/viewvc?rev=608508&view=rev
-         http://svn.apache.org/viewvc?rev=611376&view=rev
-      Backport version for 2.2.x of patch:
-         Trunk version of patch works
-      +1: rpluem, covener, trawick
-
 PATCHES PROPOSED TO BACKPORT FROM TRUNK:
   [ New proposals should be added at the end of the list ]
 

Modified: httpd/httpd/branches/2.2.x/modules/ldap/util_ldap.c
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/modules/ldap/util_ldap.c?rev=614661&r1=614660&r2=614661&view=diff
==============================================================================
--- httpd/httpd/branches/2.2.x/modules/ldap/util_ldap.c (original)
+++ httpd/httpd/branches/2.2.x/modules/ldap/util_ldap.c Wed Jan 23 12:54:16 2008
@@ -212,7 +212,9 @@
     int rc = 0, ldap_option = 0;
     int version  = LDAP_VERSION3;
     apr_ldap_err_t *result = NULL;
+#ifdef LDAP_OPT_NETWORK_TIMEOUT
     struct timeval timeOut = {10,0};    /* 10 second connection timeout */
+#endif
     util_ldap_state_t *st =
         (util_ldap_state_t *)ap_get_module_config(r->server->module_config,
         &ldap_module);
@@ -1773,9 +1775,11 @@
                                                     void *dummy,
                                                     const char *ttl)
 {
+#ifdef LDAP_OPT_NETWORK_TIMEOUT
     util_ldap_state_t *st =
         (util_ldap_state_t *)ap_get_module_config(cmd->server->module_config,
                                                   &ldap_module);
+#endif
     const char *err = ap_check_cmd_context(cmd, GLOBAL_ONLY);
 
     if (err != NULL) {

Modified: httpd/httpd/branches/2.2.x/modules/loggers/mod_log_forensic.c
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/modules/loggers/mod_log_forensic.c?rev=614661&r1=614660&r2=614661&view=diff
==============================================================================
--- httpd/httpd/branches/2.2.x/modules/loggers/mod_log_forensic.c (original)
+++ httpd/httpd/branches/2.2.x/modules/loggers/mod_log_forensic.c Wed Jan 23 12:54:16 2008
@@ -195,8 +195,8 @@
     if (!(id = apr_table_get(r->subprocess_env, "UNIQUE_ID"))) {
         /* we make the assumption that we can't go through all the PIDs in
            under 1 second */
-        id = apr_psprintf(r->pool, "%x:%lx:%x", getpid(), time(NULL),
-                          apr_atomic_inc32(&next_id));
+        id = apr_psprintf(r->pool, "%" APR_PID_T_FMT ":%lx:%x", getpid(), 
+                          time(NULL), apr_atomic_inc32(&next_id));
     }
     ap_set_module_config(r->request_config, &log_forensic_module, (char *)id);
 



Mime
View raw message