Return-Path: Delivered-To: apmail-httpd-cvs-archive@www.apache.org Received: (qmail 76727 invoked from network); 1 Dec 2007 01:34:51 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 1 Dec 2007 01:34:51 -0000 Received: (qmail 87303 invoked by uid 500); 1 Dec 2007 01:34:39 -0000 Delivered-To: apmail-httpd-cvs-archive@httpd.apache.org Received: (qmail 87255 invoked by uid 500); 1 Dec 2007 01:34:39 -0000 Mailing-List: contact cvs-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list cvs@httpd.apache.org Received: (qmail 87244 invoked by uid 99); 1 Dec 2007 01:34:39 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Nov 2007 17:34:39 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Dec 2007 01:34:27 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 9D2361A9832; Fri, 30 Nov 2007 17:34:30 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r600030 - /httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c Date: Sat, 01 Dec 2007 01:34:30 -0000 To: cvs@httpd.apache.org From: wrowe@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20071201013430.9D2361A9832@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: wrowe Date: Fri Nov 30 17:34:29 2007 New Revision: 600030 URL: http://svn.apache.org/viewvc?rev=600030&view=rev Log: Reading RFC2428 gives us no clue if case insensitivity is intended for the "EPSV ALL" command. But binding to RFC959, it's clear the case of EPSV is case insensitive, and RFC2428 doesn't illustrate this, either, so presume that "epsv all" would also be acceptable and not ambiguous. Modified: httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c Modified: httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c URL: http://svn.apache.org/viewvc/httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c?rev=600030&r1=600029&r2=600030&view=diff ============================================================================== --- httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c (original) +++ httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c Fri Nov 30 17:34:29 2007 @@ -1489,7 +1489,7 @@ const char *addr; int family = 0; - if (strcmp(arg, "ALL") == 0) { + if (strcasecmp(arg, "ALL") == 0) { /* A contract to never respond to other data connection methods */ fc->all_epsv = 1; fc->response_notes = apr_psprintf(r->pool, FTP_MSG_SUCCESS, r->method);