httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject svn commit: r600475 - /httpd/httpd/branches/2.2.x/STATUS
Date Mon, 03 Dec 2007 11:00:26 GMT
Author: rpluem
Date: Mon Dec  3 03:00:26 2007
New Revision: 600475

* Withdraw my comment / objection as I cannot follow my own arguments during
  a second review. Case I missed one dup2 call on the way what lead to my
  initial comment.


Modified: httpd/httpd/branches/2.2.x/STATUS
--- httpd/httpd/branches/2.2.x/STATUS (original)
+++ httpd/httpd/branches/2.2.x/STATUS Mon Dec  3 03:00:26 2007
@@ -114,11 +114,7 @@
      This goes all the way back to piped logs failing to run on win32.
      Not in or needed at trunk/, as apr 1.3.0 has the proper fix.
-     +1: wrowe
-     rpluem says: Is this really the correct thing to do on UNIX? I am not sure
-     if all dup2 implementation notice that both fd's are the same. Otherwise
-     they close stdout/stderr first and dup a then closed fd in stdout/stderr,
-     leaving us without stdout/stderr in the child.
+     +1: wrowe, rpluem
    * mod_proxy_http: Correctly forward unexpected interim (HTTP 1xx) responses
      incorporating ap_send_interim_response core API

View raw message