httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cove...@apache.org
Subject svn commit: r593283 - in /httpd/httpd/trunk: include/util_ldap.h modules/ldap/util_ldap.c
Date Thu, 08 Nov 2007 20:01:05 GMT
Author: covener
Date: Thu Nov  8 12:01:04 2007
New Revision: 593283

URL: http://svn.apache.org/viewvc?rev=593283&view=rev
Log:
while technically uldap_connection_cleanup() does leave an entry in the
connection list, it is fully disconnected before it's put back.  My previous
commentary did more harm then good.




Modified:
    httpd/httpd/trunk/include/util_ldap.h
    httpd/httpd/trunk/modules/ldap/util_ldap.c

Modified: httpd/httpd/trunk/include/util_ldap.h
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/include/util_ldap.h?rev=593283&r1=593282&r2=593283&view=diff
==============================================================================
--- httpd/httpd/trunk/include/util_ldap.h (original)
+++ httpd/httpd/trunk/include/util_ldap.h Thu Nov  8 12:01:04 2007
@@ -190,7 +190,7 @@
  * Cleanup a connection to an LDAP server
  * @param ldc A structure containing the expanded details of the server
  *            that was connected.
- * @tip The connection is unlocked and returned to the list of free connections
+ * @tip This functions unbinds and closes the connection to the LDAP server
  * @fn apr_status_t util_ldap_connection_cleanup(util_ldap_connection_t *ldc)
  */
 APR_DECLARE_OPTIONAL_FN(apr_status_t,uldap_connection_cleanup,(void *param));

Modified: httpd/httpd/trunk/modules/ldap/util_ldap.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/ldap/util_ldap.c?rev=593283&r1=593282&r2=593283&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/ldap/util_ldap.c (original)
+++ httpd/httpd/trunk/modules/ldap/util_ldap.c Thu Nov  8 12:01:04 2007
@@ -171,8 +171,7 @@
 
 
 /*
- * Clean up an LDAP connection by unbinding and unlocking the connection,
- * causing it to be returned to the list of free connections
+ * Clean up an LDAP connection by unbinding and unlocking the connection.
  */
 static apr_status_t uldap_connection_cleanup(void *param)
 {



Mime
View raw message