httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wr...@apache.org
Subject svn commit: r581476 - /httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c
Date Wed, 03 Oct 2007 02:33:00 GMT
Author: wrowe
Date: Tue Oct  2 19:33:00 2007
New Revision: 581476

URL: http://svn.apache.org/viewvc?rev=581476&view=rev
Log:
I found three different response codes to PORT following EPSV ALL,
so do the obvious thing and choose a fourth!

Actually 503 is the obvious choice when one considers that EPSV ALL
inhibits a sequence of another PORT/PASV/EPRT command from occuring,
and 5xx class errors represent permanant error conditions.

The users sequence of commands caused this failure, so tell them so.

Modified:
    httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c

Modified: httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c
URL: http://svn.apache.org/viewvc/httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c?rev=581476&r1=581475&r2=581476&view=diff
==============================================================================
--- httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c (original)
+++ httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c Tue Oct  2 19:33:00 2007
@@ -1391,7 +1391,7 @@
 
     if (fc->all_epsv) {
         fc->response_notes = apr_pstrdup(r->pool, "Restricted by EPSV ALL ");
-        return FTP_REPLY_COMMAND_UNRECOGNIZED;
+        return FTP_REPLY_BAD_SEQUENCE;
     }
 
     if (fc->csock) {
@@ -1718,7 +1718,7 @@
 
     if (fc->all_epsv) {
         fc->response_notes = apr_pstrdup(r->pool, "Restricted by EPSV ALL ");
-        return FTP_REPLY_COMMAND_UNRECOGNIZED;
+        return FTP_REPLY_BAD_SEQUENCE;
     }
 
     if (fc->csock) {



Mime
View raw message